Don't lock and save the orientation change made not through ScreenOrientationController

Don't lock and save the orientation change made not through ScreenOrientationController

This can happen when rotation animator sets the orientation after
animation is completed. We shouldn't save this anyway, as we changed
the semantics as follows:
a) A user/API driven rotation change in tablet mode should be treated
  as user locked rotation.
b) A user will not be able to change the orientation in tablet mode
  from settings.

BUG=734107
TEST=Manual + unit test

Review-Url: https://codereview.chromium.org/2951773002
Cr-Commit-Position: refs/heads/master@{#481027}
Committed: https://chromium.googlesource.com/chromium/src/+/b74f9beb8a7d96e0dba3556061edd4b3cc3b098d

[oshima, 2017-06-20 16:24:04]

oshima@chromium.org changed reviewers:
+ afakhry@chromium.org

[oshima, 2017-06-20 16:24:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 16:24:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-06-20 17:32:48]

lgtm

[commit-bot: I haz the power, 2017-06-20 17:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:47:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-06-20 22:54:56]

The CQ bit was checked by oshima@chromium.org

[oshima, 2017-06-20 22:54:56]

The patchset sent to the CQ was uploaded after l-g-t-m from afakhry@chromium.org
Link to the patchset: https://codereview.chromium.org/2951773002/#ps20001
(title: "removed tests that no longer makes sense")

[commit-bot: I haz the power, 2017-06-20 22:55:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:41:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497999296139940,
"parent_rev": "53fe8fd80924fbc0e06f92ec85d5a7207d65ce77", "commit_rev":
"b74f9beb8a7d96e0dba3556061edd4b3cc3b098d"}

[commit-bot: I haz the power, 2017-06-20 23:41:58]

Description was changed from

==========
Don't lock and save the orientation change made not through
ScreenOrientationController

This can happen when rotation animator sets the orientation after
animation is completed. We shouldn't save this anyway, as we changed
the semantics as follows:
a) A user/API driven rotation change in tablet mode should be treated
  as user locked rotation.
b) A user will not be able to change the orientation in tablet mode
  from settings.

BUG=734107
TEST=Manual + unit test
==========

to

==========
Don't lock and save the orientation change made not through
ScreenOrientationController

This can happen when rotation animator sets the orientation after
animation is completed. We shouldn't save this anyway, as we changed
the semantics as follows:
a) A user/API driven rotation change in tablet mode should be treated
  as user locked rotation.
b) A user will not be able to change the orientation in tablet mode
  from settings.

BUG=734107
TEST=Manual + unit test

Review-Url: https://codereview.chromium.org/2951773002
Cr-Commit-Position: refs/heads/master@{#481027}
Committed:
https://chromium.googlesource.com/chromium/src/+/b74f9beb8a7d96e0dba3556061ed...
==========

[commit-bot: I haz the power, 2017-06-20 23:42:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b74f9beb8a7d96e0dba3556061ed...