Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2951763003: Implement experimental app banner flow.

Created:
3 years, 6 months ago by benwells
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement experimental app banner flow. This change updates the flow for showing the app banner when the experimental app banner is enabled. Specifically, if the experiment flow is enabled: - by default app banners will not be shown, instead the web app needs to call event.prompt - the installability check is done on page load - preventDefault does not need to be called for e.prompt to work - a gesture is required to call e.prompt This is not the complete experimental flow - more changes are still to come. BUG=729919

Patch Set 1 #

Patch Set 2 : Browser test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M chrome/browser/android/banners/app_banner_manager_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 6 chunks +29 lines, -6 lines 0 comments Download
M chrome/browser/banners/app_banner_manager_browsertest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_manager_desktop.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/banners/app_banner_manager_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2948893004 Patch 20001

Messages

Total messages: 13 (13 generated)
benwells
The CQ bit was checked by benwells@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-21 08:18:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951763003/1
3 years, 6 months ago (2017-06-21 08:18:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-21 08:30:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/322000)
3 years, 6 months ago (2017-06-21 08:30:46 UTC) #4
benwells
The CQ bit was checked by benwells@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-21 11:14:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951763003/20001
3 years, 6 months ago (2017-06-21 11:14:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-21 11:21:30 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/452681)
3 years, 6 months ago (2017-06-21 11:21:31 UTC) #8
benwells
The CQ bit was checked by benwells@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-21 22:21:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951763003/20001
3 years, 6 months ago (2017-06-21 22:21:34 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-21 23:38:28 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-21 23:38:29 UTC) #12
benwells
3 years, 6 months ago (2017-06-22 01:32:42 UTC) #13 
Description was changed from

==========
Implement experimental app banner flow.

This change updates the flow for showing the app banner when the
experimental app banner is enabled. Specifically, if the experiment flow
is enabled:
- by default app banners will not be shown, instead the web app needs to
call event.prompt
- the installability check is done on page load
- preventDefault does not need to be called for e.prompt to work.

This is not the complete experimental flow - more changes are still to
come.

BUG=729919
==========

to

==========
Implement experimental app banner flow.

This change updates the flow for showing the app banner when the
experimental app banner is enabled. Specifically, if the experiment flow
is enabled:
- by default app banners will not be shown, instead the web app needs to
call event.prompt
- the installability check is done on page load
- preventDefault does not need to be called for e.prompt to work
- a gesture is required to call e.prompt

This is not the complete experimental flow - more changes are still to
come.

BUG=729919
==========

Powered by Google App Engine
This is Rietveld 408576698