Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2951753002: Replace a DCHECK in BVC with an early return. (Closed)

Created:
3 years, 6 months ago by stkhapugin
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace a DCHECK in BVC with an early return. This is a temporary fix to suppress a crash in BVC when tools menu is opened with no active tab. BUG=731045 Review-Url: https://codereview.chromium.org/2951753002 Cr-Commit-Position: refs/heads/master@{#480819} Committed: https://chromium.googlesource.com/chromium/src/+/098a1ea16309186de2ae8f6386a8253346b37edd

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
stkhapugin
PTAL
3 years, 6 months ago (2017-06-20 13:56:28 UTC) #2
rohitrao (ping after 24h)
lgtm Is the goal to eventually figure out why currentTab is nil and remove this ...
3 years, 6 months ago (2017-06-20 14:02:44 UTC) #3
stkhapugin
https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/browser_view_controller.mm File ios/chrome/browser/ui/browser_view_controller.mm (right): https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/browser_view_controller.mm#newcode4407 ios/chrome/browser/ui/browser_view_controller.mm:4407: if (![_model currentTab]) { On 2017/06/20 14:02:44, rohitrao (ping ...
3 years, 6 months ago (2017-06-20 14:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951753002/20001
3 years, 6 months ago (2017-06-20 14:35:30 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 14:47:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/098a1ea16309186de2ae8f6386a8...

Powered by Google App Engine
This is Rietveld 408576698