Replace a DCHECK in BVC with an early return.

Replace a DCHECK in BVC with an early return.

This is a temporary fix to suppress a crash in BVC when tools menu is
opened with no active tab.

BUG=731045
Review-Url: https://codereview.chromium.org/2951753002
Cr-Commit-Position: refs/heads/master@{#480819}
Committed: https://chromium.googlesource.com/chromium/src/+/098a1ea16309186de2ae8f6386a8253346b37edd

[stkhapugin, 2017-06-20 13:56:27]

stkhapugin@chromium.org changed reviewers:
+ rohitrao@chromium.org

[stkhapugin, 2017-06-20 13:56:28]

PTAL

[rohitrao (ping after 24h), 2017-06-20 14:02:44]

lgtm

Is the goal to eventually figure out why currentTab is nil and remove this early
return?  If so, how are we going to figure this out?

https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4407: if (![_model currentTab])
{
Consider adding a link to the crbug and explaining why this early return exists.

[stkhapugin, 2017-06-20 14:09:42]

https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/brows...
File ios/chrome/browser/ui/browser_view_controller.mm (right):

https://codereview.chromium.org/2951753002/diff/1/ios/chrome/browser/ui/brows...
ios/chrome/browser/ui/browser_view_controller.mm:4407: if (![_model currentTab])
{
On 2017/06/20 14:02:44, rohitrao (ping after 24h) wrote:
> Consider adding a link to the crbug and explaining why this early return
exists.

Done.

[stkhapugin, 2017-06-20 14:35:19]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-06-20 14:35:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2951753002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-06-20 14:35:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 14:47:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497969319342750,
"parent_rev": "bf76fd9adfb3e875144b070fba3415d8e592baf8", "commit_rev":
"098a1ea16309186de2ae8f6386a8253346b37edd"}

[commit-bot: I haz the power, 2017-06-20 14:47:45]

Description was changed from

==========
Replace a DCHECK in BVC with an early return.

This is a temporary fix to suppress a crash in BVC when tools menu is
opened with no active tab.

BUG=731045
==========

to

==========
Replace a DCHECK in BVC with an early return.

This is a temporary fix to suppress a crash in BVC when tools menu is
opened with no active tab.

BUG=731045

Review-Url: https://codereview.chromium.org/2951753002
Cr-Commit-Position: refs/heads/master@{#480819}
Committed:
https://chromium.googlesource.com/chromium/src/+/098a1ea16309186de2ae8f6386a8...
==========

[commit-bot: I haz the power, 2017-06-20 14:47:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/098a1ea16309186de2ae8f6386a8...