Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2951633002: chromium.fyi: Increase timeout for linux_layout_tests_layout_ng (Closed)

Created:
3 years, 6 months ago by mithro
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951633002/1
3 years, 6 months ago (2017-06-19 23:45:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ee2d0f36c75e78a4613e8217a3c8ef6be4def5db
3 years, 6 months ago (2017-06-19 23:51:14 UTC) #10
Dirk Pranke
This CL doesn't seem to make sense, and I'm not sure why it was TBR'ed? ...
3 years, 6 months ago (2017-06-19 23:54:13 UTC) #11
mithro
3 years, 6 months ago (2017-06-20 00:35:47 UTC) #12
Message was sent while issue was closed.
On 2017/06/19 23:54:13, Dirk Pranke wrote:
> This CL doesn't seem to make sense, and I'm not sure why it was TBR'ed?
> 
> Why would you increase *both* the number of shards that you're using, *and*
the
> timeout. And, why such a huge timeout? Now you can potentially lock up 15
> different bots for a hundred minutes each, and that seems bad?

I'm setting the numbers larger than I think are needed to see if it makes the
bot go green. If things are good we can see what the value should actually be.

Powered by Google App Engine
This is Rietveld 408576698