Issue 2951503002: Merge "Make profile error dialog async"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2951503002: Merge "Make profile error dialog async" (Closed)

Created:
3 years, 6 months ago by xiyuan

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Merge "Make profile error dialog async" > So that it does not run a nested message loop to block mojo > messages. > > BUG=729701 > > Review-Url: https://codereview.chromium.org/2929953002 > Cr-Commit-Position: refs/heads/master@{#479389} > (cherry picked from commit 2404367d4408db72ffdda3a5d7e520ce9c4f4590) Review-Url: https://codereview.chromium.org/2951503002 . Cr-Commit-Position: refs/branch-heads/3112@{#384} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/225f572b6d2972587c31a2e6d3a8efe82cc0d5ca

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -83 lines)			Patch
M	chrome/browser/ui/android/simple_message_box_android.cc	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/simple_message_box_mac.mm	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/profile_error_dialog.cc	View	3 chunks	+32 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/simple_message_box.h	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/simple_message_box_views.cc	View	13 chunks	+83 lines, -44 lines	0 comments	Download

Total messages: 2 (1 generated)

xiyuan

3 years, 6 months ago (2017-06-19 17:24:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
225f572b6d2972587c31a2e6d3a8efe82cc0d5ca.