chrome/browser/resources/settings/device_page/night_light_slider.html - Issue 2951483003: [Night Light] CL9: Add localization for time's AM and PM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/night_light_slider.html

Issue 2951483003: [Night Light] CL9: Add localization for time's AM and PM (Closed)

Patch Set: toLocaleTimeString() Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/device_page/night_light_slider.js » ('j') | chrome/browser/resources/settings/device_page/night_light_slider.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/device_page/night_light_slider.html

diff --git a/chrome/browser/resources/settings/device_page/night_light_slider.html b/chrome/browser/resources/settings/device_page/night_light_slider.html

index 317a1c35b700719999cdbdacb2c88146a35976f8..386b168884bb91e3d65f1c767e5db2cbf43f2a0e 100644

--- a/chrome/browser/resources/settings/device_page/night_light_slider.html

+++ b/chrome/browser/resources/settings/device_page/night_light_slider.html

@@ -149,12 +149,11 @@

on-up="endDrag_" on-track="continueDrag_"></div>

</div>

-

- <div style="left: 0%;">6 PM</div>

- <div style="left: 25%;">12 AM</div>

- <div style="left: 50%;">6 AM</div>

- <div style="left: 75%;">12 PM</div>

- <div style="left: 100%;">6 PM</div>

+ <div style="left: 0%;">$i18n{displayNightLightLegend6Pm}</div>

+ <div style="left: 25%;">$i18n{displayNightLightLegend12Am}</div>

+ <div style="left: 50%;">$i18n{displayNightLightLegend6Am}</div>

+ <div style="left: 75%;">$i18n{displayNightLightLegend12Pm}</div>

+ <div style="left: 100%;">$i18n{displayNightLightLegend6Pm}</div>

stevenjb 2017/06/20 17:25:56 Rather than requiring translation of these strings

afakhry 2017/06/20 18:10:34 Yes, thanks! I used our existing offsetMinutesToTi

</div>