Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2951483002: TEST Check that PageTransition keeps bf flag

Created:
3 years, 6 months ago by clamy
Modified:
3 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

TEST Check that PageTransition keeps bf flag BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (6 generated)
nasko
https://codereview.chromium.org/2951483002/diff/1/content/browser/frame_host/navigation_handle_impl.cc File content/browser/frame_host/navigation_handle_impl.cc (right): https://codereview.chromium.org/2951483002/diff/1/content/browser/frame_host/navigation_handle_impl.cc#newcode747 content/browser/frame_host/navigation_handle_impl.cc:747: params.transition & ui::PAGE_TRANSITION_FORWARD_BACK); One of the cases where this ...
3 years, 6 months ago (2017-06-23 13:40:39 UTC) #7
clamy
3 years, 6 months ago (2017-06-23 13:42:26 UTC) #8
Thanks! So that's not the case we're looking for, where the bf transition is
dropped at commit time. I'm going to upload a new version of the patch to check
for this specifically.

Powered by Google App Engine
This is Rietveld 408576698