TEST Check that PageTransition keeps bf flag

content/browser/frame_host/navigation_handle_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_handle_impl.h"
 
 #include <iterator>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 725 matching lines @@
     const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
     bool navigation_entry_committed,
     bool did_replace_entry,
     const GURL& previous_url,
     NavigationType navigation_type,
     RenderFrameHostImpl* render_frame_host) {
   DCHECK(!render_frame_host_ || render_frame_host_ == render_frame_host);
   DCHECK_EQ(frame_tree_node_, render_frame_host->frame_tree_node());
   CHECK_EQ(url_, params.url);
 
+  CHECK_EQ(transition_ & ui::PAGE_TRANSITION_FORWARD_BACK,
+           params.transition & ui::PAGE_TRANSITION_FORWARD_BACK);

[nasko, 2017/06/23 13:40:38]

One of the cases where this is hit is for history navigation to a NavEntry
result from pushState. The handle starts with empty page transition, we don't
have a network request to update it, then at commit time we get a back/forward
transition, which doesn't match the empty transition.

+
   did_replace_entry_ = did_replace_entry;
   method_ = params.method;
   has_user_gesture_ = (params.gesture == NavigationGestureUser);
   transition_ = params.transition;
   should_update_history_ = params.should_update_history;
   render_frame_host_ = render_frame_host;
   previous_url_ = previous_url;
   base_url_ = params.base_url;
   socket_address_ = params.socket_address;
   navigation_type_ = navigation_type;
@@ skipping 402 matching lines @@
   if (new_site_url == site_url_)
     return;
 
   // When redirecting cross-site, stop telling the speculative
   // RenderProcessHost to expect a navigation commit.
   SetExpectedProcess(nullptr);
   site_url_ = new_site_url;
 }
 
 }  // namespace content