tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: more refactor Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« grpc/grpcutil/errors.go ('K') | « tokenserver/appengine/impl/machinetoken/machinetoken.go ('k') | tokenserver/appengine/impl/machinetoken/rpc_mint_machine_token.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go

diff --git a/tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go b/tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go

index 968c58d9fca872cb429a256432b76d4012334ef2..019305a7834ef82d51be4daef7e90bed817e8f20 100644

--- a/tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go

+++ b/tokenserver/appengine/impl/machinetoken/rpc_inspect_machine_token.go

@@ -12,7 +12,7 @@ import (

"google.golang.org/grpc"

"google.golang.org/grpc/codes"

- "github.com/luci/luci-go/common/errors"

+ "github.com/luci/luci-go/common/retry/transient"

"github.com/luci/luci-go/server/auth/signing"

tokenserver "github.com/luci/luci-go/tokenserver/api"

@@ -95,7 +95,7 @@ func (r *InspectMachineTokenRPC) InspectMachineToken(c context.Context, req *adm

// Grab CertChecker for this CA. It has CRL cached.

certChecker, err := certchecker.GetCertChecker(c, caName)

switch {

- case errors.IsTransient(err):

+ case transient.Tag.In(err):

return nil, grpc.Errorf(codes.Internal, "can't fetch CRL - %s", err)

case err != nil:

addReason(fmt.Sprintf("can't fetch CRL - %s", err))