tokenserver/appengine/impl/machinetoken/machinetoken.go - Issue 2951393002: [errors] de-specialize Transient in favor of Tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tokenserver/appengine/impl/machinetoken/machinetoken.go

Issue 2951393002: [errors] de-specialize Transient in favor of Tags. (Closed)

Patch Set: more refactor Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tokenserver/appengine/impl/machinetoken/machinetoken.go

diff --git a/tokenserver/appengine/impl/machinetoken/machinetoken.go b/tokenserver/appengine/impl/machinetoken/machinetoken.go

index c43095aeeb0a1bdbde7dc241b15b6f930b698ec9..f0b1ae363b48f0068e3ce86e690a0356c0e5a3bb 100644

--- a/tokenserver/appengine/impl/machinetoken/machinetoken.go

+++ b/tokenserver/appengine/impl/machinetoken/machinetoken.go

@@ -18,7 +18,7 @@ import (

"golang.org/x/net/context"

"github.com/luci/luci-go/common/clock"

- "github.com/luci/luci-go/common/errors"

+ "github.com/luci/luci-go/common/retry/transient"

"github.com/luci/luci-go/server/auth/signing"

"github.com/luci/luci-go/tokenserver/api"

@@ -126,7 +126,7 @@ func Mint(c context.Context, params *MintParams) (*tokenserver.MachineTokenBody,

srvInfo, err := params.Signer.ServiceInfo(c)

if err != nil {

- return nil, "", errors.WrapTransient(err)

+ return nil, "", transient.Tag.Apply(err)

}

body := &tokenserver.MachineTokenBody{