Extensions Cleanup: Simplify how code for IPC::ParamTraits<Manifest::Location> is generated.

Extensions Cleanup: Simplify how code for IPC::ParamTraits<Manifest::Location> is generated.

Currently, code for IPC::ParamTraits<Manifest::Location> is generated using a
separate generator file. Simplify this by generating this as part of
extension_message_generator.

BUG=None

Review-Url: https://codereview.chromium.org/2951383003
Cr-Commit-Position: refs/heads/master@{#481968}
Committed: https://chromium.googlesource.com/chromium/src/+/49d85c9757fcbb563aafcfca3910572a032d8cd3

[karandeepb, 2017-06-23 03:43:04]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-23 03:43:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2017-06-23 04:38:18]

karandeepb@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[karandeepb, 2017-06-23 04:38:19]

PTAL Devlin.

[Devlin, 2017-06-23 05:40:28]

rdevlin.cronin@chromium.org changed reviewers:
+ rockot@chromium.org

[Devlin, 2017-06-23 05:40:29]

My IPC -> mojo knowledge is still pretty basic, but I remember bringing this up
in
https://codereview.chromium.org/2697463002/diff/340001/extensions/common/mani....
 At the time, it seems like this was necessary.  If it isn't any more - great! 
But I'd like a mojo guru to take a look and confirm first. :)

[commit-bot: I haz the power, 2017-06-23 05:44:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:44:45]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2017-06-23 05:49:04]

On 2017/06/23 at 05:40:29, rdevlin.cronin wrote:
> My IPC -> mojo knowledge is still pretty basic, but I remember bringing this
up in
https://codereview.chromium.org/2697463002/diff/340001/extensions/common/mani....
 At the time, it seems like this was necessary.  If it isn't any more - great! 
But I'd like a mojo guru to take a look and confirm first. :)

This doesn't actually have anything to do with Mojo. The CL which added these
ParamTraits appears to have simply done it wrong. I suppose I should have caught
that since I was a reviewer on the CL. :o

Anyway, this is the correct way to use param traits generation macros, so this
change LGTM.

[karandeepb, 2017-06-23 18:24:56]

karandeepb@chromium.org changed reviewers:
+ dcheng@chromium.org

[karandeepb, 2017-06-23 18:24:56]

PTAL dcheng@ for IPC security review.

[dcheng, 2017-06-23 18:27:46]

LGTM, though I'm not sure the CL description is accurate?

[dcheng, 2017-06-23 18:28:43]

(Basically when I see "explicit template specialization", I expect to see a C++
explicit template specialization change, but there's nothing like that in
this--it's just changing how we expand for the preprocessor so we don't need to
have a separate generator .cc)

[karandeepb, 2017-06-23 18:39:22]

Description was changed from

==========
Extensions Cleanup: Remove explicit template specialization for
IPC::ParamTraits<Manifest::Location>.

Currently, manifest_location_param_traits.cc explicity generates template
specialization for IPC::ParamTraits<Manifest::Location>. Simplify this by
generating this as part of extension_message_generator.

BUG=None
==========

to

==========
Extensions Cleanup: Simplify how code for IPC::ParamTraits<Manifest::Location>
is generated.

Currently, code for IPC::ParamTraits<Manifest::Location> is generated using a
separate generator file. Simplify this by generating this as part of
extension_message_generator.

BUG=None
==========

[karandeepb, 2017-06-23 18:40:02]

On 2017/06/23 18:28:43, dcheng wrote:
> (Basically when I see "explicit template specialization", I expect to see a
C++
> explicit template specialization change, but there's nothing like that in
> this--it's just changing how we expand for the preprocessor so we don't need
to
> have a separate generator .cc)

Think it should be fine now.

[karandeepb, 2017-06-23 18:40:23]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2017-06-23 18:40:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 18:44:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498243223916190, "parent_rev":
"e74ac8e7f0a8ab5e6f08666158abadf34f2ed7fe", "commit_rev":
"49d85c9757fcbb563aafcfca3910572a032d8cd3"}

[commit-bot: I haz the power, 2017-06-23 18:44:29]

Description was changed from

==========
Extensions Cleanup: Simplify how code for IPC::ParamTraits<Manifest::Location>
is generated.

Currently, code for IPC::ParamTraits<Manifest::Location> is generated using a
separate generator file. Simplify this by generating this as part of
extension_message_generator.

BUG=None
==========

to

==========
Extensions Cleanup: Simplify how code for IPC::ParamTraits<Manifest::Location>
is generated.

Currently, code for IPC::ParamTraits<Manifest::Location> is generated using a
separate generator file. Simplify this by generating this as part of
extension_message_generator.

BUG=None

Review-Url: https://codereview.chromium.org/2951383003
Cr-Commit-Position: refs/heads/master@{#481968}
Committed:
https://chromium.googlesource.com/chromium/src/+/49d85c9757fcbb563aafcfca3910...
==========

[commit-bot: I haz the power, 2017-06-23 18:44:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/49d85c9757fcbb563aafcfca3910...