Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2951323003: LayoutTests: Disabling tests on Mac which depend on GPU configuration. (Closed)

Created:
3 years, 6 months ago by mithro
Modified:
3 years, 6 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: Disabling tests on Mac which depend on GPU configuration. This is a temporary measure to allow Layout Tests on Swarming to be deployed on Mac while a solution to the problem is investigated. This should also prevent developers from hitting this on their machine locally. BUG=736177 TBR=kbr@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,ericrk@chromium.org,enne@chromium.org,dpranke@chromium.org,ccameron@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2951323003 Cr-Commit-Position: refs/heads/master@{#481819} Committed: https://chromium.googlesource.com/chromium/src/+/63fbf039ec4812b82cfcff282a24c3464f34876e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +64 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
mithro
Hello everyone, At Dirk's suggestion I'm disabling all the tests which currently fail on the ...
3 years, 6 months ago (2017-06-23 05:58:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951323003/1
3 years, 6 months ago (2017-06-23 06:27:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/63fbf039ec4812b82cfcff282a24c3464f34876e
3 years, 6 months ago (2017-06-23 06:40:10 UTC) #11
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-23 16:08:24 UTC) #12
Ken Russell (switch to Gerrit)
3 years, 6 months ago (2017-06-23 20:39:41 UTC) #13
Message was sent while issue was closed.
Understanding why these tests are failing and re-enabling them should be made a
top priority. There are a large number of failures here.

Powered by Google App Engine
This is Rietveld 408576698