src/array.js - Issue 29513004: Make Array.prototype.pop throw if the last element is not configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 29513004: Make Array.prototype.pop throw if the last element is not configurable. (Closed) Base URL: https://github.com/v8/v8.git@master

Patch Set: remove some unnecessary effect. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index 4a7aea5e1d9fd358cd679ae0f534e8d6bed1f257..b8f50829c93f98790188c1b72f81bd26534967c0 100644

--- a/src/array.js

+++ b/src/array.js

@@ -430,7 +430,7 @@ function ArrayPop() {

n--;

var value = this[n];

- delete this[n];

+ Delete(this, ToName(n), true);

this.length = n;

return value;

}

« no previous file with comments | « no previous file | tools/presubmit.py » ('j') | tools/presubmit.py » ('J')