Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 29513003: Cleanup deprecated and no longer needed blob revamp stuff, deadcode. (Closed)

Created:
7 years, 2 months ago by michaeln
Modified:
7 years ago
Reviewers:
kinuko
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch
Visibility:
Public.

Description

Cleanup deprecated and no longer needed blob revamp stuff, deadcode. R=kinuko@chromium.org TBR=darin BUG=174200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230237

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -419 lines) Patch
M chrome/renderer/extensions/feedback_private_custom_bindings.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 3 4 4 chunks +0 lines, -34 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/child/fileapi/webfilewriter_base.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/child/fileapi/webfilewriter_base.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/child/fileapi/webfilewriter_base_unittest.cc View 1 2 15 chunks +25 lines, -57 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M content/child/webblobregistry_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/child/webblobregistry_impl.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M content/common/fileapi/webblob_messages.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/common/page_state_serialization.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/page_state_serialization.cc View 5 chunks +0 lines, -27 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/resource_messages.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/public/renderer/history_item_serialization.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 3 chunks +0 lines, -9 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.cc View 3 chunks +1 line, -27 lines 0 comments Download
M webkit/browser/blob/blob_storage_host.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webkit/browser/blob/blob_storage_host.cc View 2 chunks +0 lines, -54 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job_factory.cc View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/browser/blob/view_blob_internals_job.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/child/weburlloader_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/common/blob/blob_data.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/common/blob/blob_data.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/common/data_element.h View 5 chunks +1 line, -13 lines 0 comments Download
M webkit/common/data_element.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M webkit/common/resource_request_body.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/resource_request_body.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
michaeln
ptal (simple slogging)
7 years, 2 months ago (2013-10-18 22:59:21 UTC) #1
kinuko
lgtm!
7 years, 2 months ago (2013-10-19 04:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/29513003/110001
7 years, 2 months ago (2013-10-20 04:52:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31457
7 years, 2 months ago (2013-10-20 05:10:59 UTC) #4
kinuko
On 2013/10/20 05:10:59, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 2 months ago (2013-10-21 01:26:02 UTC) #5
michaeln
> (Sorry, clicked it too early) tbr'ing darin for deletion of dead code
7 years, 2 months ago (2013-10-22 01:42:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/29513003/250001
7 years, 2 months ago (2013-10-22 01:46:09 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-22 01:59:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/29513003/250001
7 years, 2 months ago (2013-10-22 03:35:58 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-22 03:38:59 UTC) #10
michaeln
Committed patchset #5 manually as r230237 (presubmit successful).
7 years, 2 months ago (2013-10-22 22:47:09 UTC) #11
michaeln
7 years, 2 months ago (2013-10-22 23:00:12 UTC) #12
Message was sent while issue was closed.
On 2013/10/22 22:47:09, michaeln wrote:
> Committed patchset #5 manually as r230237 (presubmit successful).

wow, look at this output from git cl dcommit... i'll just ignore all that junk
about unable to delete and empty directory warnings... sure hope nothing
important is in there and hope that the changes i intended to commit are
actually what got committed...

Review URL: https://codereview.chromium.org/29513003
 .../extensions/feedback_private_custom_bindings.cc |  4 --
 content/browser/fileapi/fileapi_message_filter.cc  | 34 ---------
 content/browser/fileapi/fileapi_message_filter.h   | 12 ----
 .../browser/loader/upload_data_stream_builder.cc   |  5 +-
 content/child/fileapi/webfilewriter_base.cc        |  8 ---
 content/child/fileapi/webfilewriter_base.h         |  6 --
 .../child/fileapi/webfilewriter_base_unittest.cc   | 82 +++++++---------------
 content/child/fileapi/webfilewriter_impl.cc        | 22 ------
 content/child/fileapi/webfilewriter_impl.h         |  2 -
 content/child/webblobregistry_impl.cc              | 34 ---------
 content/child/webblobregistry_impl.h               |  8 ---
 content/common/fileapi/webblob_messages.h          | 12 ----
 content/common/page_state_serialization.cc         | 27 -------
 content/common/page_state_serialization.h          |  4 --
 .../common/page_state_serialization_unittest.cc    |  4 --
 content/common/resource_messages.cc                |  9 +--
 .../public/renderer/history_item_serialization.cc  |  8 ---
 webkit/browser/blob/blob_storage_context.cc        | 28 +-------
 webkit/browser/blob/blob_storage_context.h         |  9 ---
 webkit/browser/blob/blob_storage_host.cc           | 54 --------------
 webkit/browser/blob/blob_storage_host.h            | 10 ---
 .../browser/blob/blob_url_request_job_factory.cc   |  9 +--
 webkit/browser/blob/view_blob_internals_job.cc     | 12 ----
 webkit/child/weburlloader_impl.cc                  |  4 --
 webkit/common/blob/blob_data.cc                    |  6 --
 webkit/common/blob/blob_data.h                     |  5 --
 webkit/common/data_element.cc                      | 11 ---
 webkit/common/data_element.h                       | 14 +---
 webkit/common/resource_request_body.cc             |  5 --
 webkit/common/resource_request_body.h              |  1 -
 30 files changed, 30 insertions(+), 419 deletions(-)
About to commit; enter to confirm.
warning: unable to rmdir breakpad/src: Directory not empty
warning: unable to rmdir
chrome/test/data/extensions/api_test/permissions/nacl_enabled/bin: Directory n
warning: unable to rmdir chrome/test/data/perf/canvas_bench: Directory not empty
warning: unable to rmdir chrome/test/data/perf/frame_rate/content: Directory not
empty
warning: unable to rmdir chrome/test/data/perf/third_party/octane: Directory not
empty
warning: unable to rmdir chrome/tools/test/reference_build/chrome_win: Directory
not empty
warning: unable to rmdir chrome_frame/tools/test/reference_build/chrome_win:
Directory not empty
warning: unable to rmdir media/cdm/ppapi/api: Directory not empty
warning: unable to rmdir native_client: Directory not empty
warning: unable to rmdir sdch/open-vcdiff: Directory not empty
warning: unable to rmdir testing/gmock: Directory not empty
warning: unable to rmdir testing/gtest: Directory not empty
warning: unable to rmdir third_party/WebKit: Directory not empty
warning: unable to rmdir third_party/angle_dx11: Directory not empty
warning: unable to rmdir third_party/bidichecker: Directory not empty
warning: unable to rmdir third_party/bison: Directory not empty
warning: unable to rmdir third_party/cacheinvalidation/src: Directory not empty
warning: unable to rmdir third_party/cld_2/src: Directory not empty
warning: unable to rmdir third_party/cygwin: Directory not empty
warning: unable to rmdir third_party/ffmpeg: Directory not empty
warning: unable to rmdir third_party/flac: Directory not empty
warning: unable to rmdir third_party/gnu_binutils: Directory not empty
warning: unable to rmdir third_party/gperf: Directory not empty
warning: unable to rmdir third_party/hunspell: Directory not empty
warning: unable to rmdir third_party/hunspell_dictionaries: Directory not empty
warning: unable to rmdir third_party/icu: Directory not empty
warning: unable to rmdir third_party/jsoncpp/source/include: Directory not empty
warning: unable to rmdir third_party/jsoncpp/source/src/lib_json: Directory not
empty
warning: unable to rmdir third_party/leveldatabase/src: Directory not empty
warning: unable to rmdir third_party/libexif/sources: Directory not empty
warning: unable to rmdir third_party/libjingle/source/talk: Directory not empty
warning: unable to rmdir third_party/libjpeg_turbo: Directory not empty
warning: unable to rmdir third_party/libphonenumber/src/phonenumbers: Directory
not empty
warning: unable to rmdir third_party/libphonenumber/src/resources: Directory not
empty
warning: unable to rmdir third_party/libphonenumber/src/test: Directory not
empty
warning: unable to rmdir third_party/libsrtp: Directory not empty
warning: unable to rmdir third_party/libvpx: Directory not empty
warning: unable to rmdir third_party/libyuv: Directory not empty
warning: unable to rmdir third_party/lighttpd: Directory not empty
warning: unable to rmdir third_party/mesa/src: Directory not empty
warning: unable to rmdir third_party/mingw-w64/mingw/bin: Directory not empty
warning: unable to rmdir third_party/nacl_sdk_binaries: Directory not empty
warning: unable to rmdir third_party/nss: Directory not empty
warning: unable to rmdir third_party/openmax_dl: Directory not empty
warning: unable to rmdir third_party/opus/src: Directory not empty
warning: unable to rmdir third_party/ots: Directory not empty
warning: unable to rmdir third_party/pefile: Directory not empty
warning: unable to rmdir third_party/perl: Directory not empty
warning: unable to rmdir third_party/psyco_win32: Directory not empty
warning: unable to rmdir third_party/pyftpdlib/src: Directory not empty
warning: unable to rmdir third_party/pymox/src: Directory not empty
warning: unable to rmdir third_party/python_26: Directory not empty
warning: unable to rmdir third_party/pywebsocket/src: Directory not empty
warning: unable to rmdir third_party/safe_browsing/testing: Directory not empty
warning: unable to rmdir third_party/scons-2.0.1: Directory not empty
warning: unable to rmdir third_party/sfntly/cpp/src: Directory not empty
warning: unable to rmdir third_party/skia/gyp: Directory not empty
warning: unable to rmdir third_party/skia/include: Directory not empty
warning: unable to rmdir third_party/skia/src: Directory not empty
warning: unable to rmdir third_party/smhasher/src: Directory not empty
warning: unable to rmdir third_party/snappy/src: Directory not empty
warning: unable to rmdir third_party/speex: Directory not empty
warning: unable to rmdir third_party/swig/Lib: Directory not empty
warning: unable to rmdir third_party/swig/win: Directory not empty
warning: unable to rmdir third_party/syzygy/binaries: Directory not empty
warning: unable to rmdir third_party/trace-viewer: Directory not empty
warning: unable to rmdir third_party/undoview: Directory not empty
warning: unable to rmdir third_party/usrsctp/usrsctplib: Directory not empty
warning: unable to rmdir third_party/v8-i18n: Directory not empty
warning: unable to rmdir third_party/webdriver/pylib: Directory not empty
warning: unable to rmdir third_party/webgl_conformance: Directory not empty
warning: unable to rmdir third_party/webpagereplay: Directory not empty
warning: unable to rmdir third_party/webrtc: Directory not empty
warning: unable to rmdir third_party/xulrunner-sdk: Directory not empty
warning: unable to rmdir third_party/yasm/binaries: Directory not empty
warning: unable to rmdir third_party/yasm/source/patched-yasm: Directory not
empty
warning: unable to rmdir tools/deps2git: Directory not empty
warning: unable to rmdir tools/grit: Directory not empty
warning: unable to rmdir tools/gyp: Directory not empty
warning: unable to rmdir tools/page_cycler/acid3: Directory not empty
warning: unable to rmdir tools/swarm_client: Directory not empty
warning: unable to rmdir v8: Directory not empty
Switched to branch 'git-cl-cherry-pick'
W: +empty_dir: trunk/src/third_party/liblouis
W: -empty_dir: trunk/src/net/android/x509_util.cc
W: -empty_dir: trunk/src/net/android/x509_util.h
W: -empty_dir: trunk/src/chrome/common/extensions/api/webrtc_udp_transport.idl
W: -empty_dir:
trunk/src/chrome/renderer/resources/extensions/webrtc_udp_transport_custom_bindings.js
Closing issue (you may be prompted for your codereview password)...

Powered by Google App Engine
This is Rietveld 408576698