Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2951293003: Reland of Experiment to add bank name in autofill ui. (Closed)

Created:
3 years, 6 months ago by Shanfeng
Modified:
3 years, 6 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Original CL: https://codereview.chromium.org/2711543002 Revert CL: https://codereview.chromium.org/2948943003 This Cl is to revert the revert, since the issue has been identified and not related. Detailed in crbug.com/735574 BUG=734265 TBR=mathp@chromium.org, rkaplow@chromium.org, pkasting@chromium.org, sebsg@chromium.org Review-Url: https://codereview.chromium.org/2711543002 Cr-Commit-Position: refs/heads/master@{#481059} Committed: https://chromium.googlesource.com/chromium/src/+/b0045cb0dec61387b7cc05049c2878b406bc298b patch from issue 2711543002 at patchset 700001 (http://crrev.com/2711543002#ps700001) Review-Url: https://codereview.chromium.org/2951293003 Cr-Commit-Position: refs/heads/master@{#481740} Committed: https://chromium.googlesource.com/chromium/src/+/b9da01ced5ef7574fe8a1ee0b57d01a54f5279c2

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 3 chunks +15 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 5 chunks +20 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 9 chunks +143 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.h View 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 2 chunks +32 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +6 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 chunks +69 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 8 chunks +28 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
A components/test/data/web_database/version_72.sql View 1 chunk +32 lines, -0 lines 0 comments Download
M components/webdata/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/webdata/common/web_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +40 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 3 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951293003/20001
3 years, 6 months ago (2017-06-22 20:55:57 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 20:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951293003/20001
3 years, 6 months ago (2017-06-22 20:59:25 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 20:59:27 UTC) #11
sebsg
lgtm
3 years, 6 months ago (2017-06-22 21:17:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951293003/20001
3 years, 6 months ago (2017-06-22 21:18:33 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:23:02 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9da01ced5ef7574fe8a1ee0b57d...

Powered by Google App Engine
This is Rietveld 408576698