Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2951233002: media: Implement MojoVideoDecoder::CanReadWithoutStalling(). (Closed)

Created:
3 years, 6 months ago by sandersd (OOO until July 31)
Modified:
3 years, 6 months ago
Reviewers:
watk, dcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Implement MojoVideoDecoder::CanReadWithoutStalling(). This implementation is quite conservative; it only allows changes at the same time as outputting a VideoFrame. This is fine, since the value is irrelevant before the first frame, and the only dynamic case (GpuVideoDecoder) changes values exactly on output. BUG=522298 Review-Url: https://codereview.chromium.org/2951233002 Cr-Commit-Position: refs/heads/master@{#481989} Committed: https://chromium.googlesource.com/chromium/src/+/7e2b9f8c41a053a3ca06552808a247e576258593

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M media/mojo/clients/mojo_video_decoder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_video_decoder.cc View 2 chunks +7 lines, -1 line 0 comments Download
M media/mojo/interfaces/video_decoder.mojom View 1 chunk +10 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_video_decoder_service.cc View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sandersd (OOO until July 31)
3 years, 6 months ago (2017-06-22 00:47:53 UTC) #2
watk
lgtm
3 years, 6 months ago (2017-06-23 00:23:44 UTC) #4
sandersd (OOO until July 31)
dcheng@: Please review changes in video_decoder.mojom.
3 years, 6 months ago (2017-06-23 00:33:53 UTC) #7
dcheng
lgtm
3 years, 6 months ago (2017-06-23 08:11:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951233002/20001
3 years, 6 months ago (2017-06-23 17:37:45 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 19:31:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e2b9f8c41a053a3ca06552808a2...

Powered by Google App Engine
This is Rietveld 408576698