Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8608)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox.gyp

Issue 295123002: Provide script/gypi support for manifest generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Support Jinja2. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/chromevox.gyp
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox.gyp b/chrome/browser/resources/chromeos/chromevox/chromevox.gyp
index 6bc51f83b67b3b962c6422e3156176289ebab06a..8b9ec3163b4ca78a58169df43ce74720b8fe92cd 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox.gyp
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox.gyp
@@ -12,6 +12,8 @@
'type': 'none',
'dependencies': [
'chromevox_assets',
+ 'chromevox_manifest',
+ 'chromevox_guest_manifest',
'chromevox_static_files',
'chromevox_strings',
'chromevox_uncompiled_js_files',
@@ -181,5 +183,24 @@
},
],
},
+ {
+ 'target_name': 'chromevox_manifest',
+ 'type': 'none',
+ 'variables': {
+ 'template_manifest': 'manifest.json.jinja2',
+ 'output_manifest': '<(PRODUCT_DIR)/resources/chromeos/chromevox/manifest.json',
Peter Lundblad 2014/05/23 16:04:27 Use chromevox_dest_dir here.
David Tseng 2014/05/23 19:16:37 Done.
+ },
+ 'includes': [ 'generate_manifest.gypi', ],
+ },
+ {
+ 'target_name': 'chromevox_guest_manifest',
+ 'type': 'none',
+ 'variables': {
+ 'template_manifest': 'manifest.json.jinja2',
Peter Lundblad 2014/05/23 16:04:27 Move this outside to avoid duplication.
David Tseng 2014/05/23 19:16:37 Done.
+ 'output_manifest': '<(PRODUCT_DIR)/resources/chromeos/chromevox/manifest_guest.json',
Peter Lundblad 2014/05/23 16:04:27 chromevox_dest_dir
David Tseng 2014/05/23 19:16:37 Done.
+ 'is_guest_manifest': 1,
+ },
+ 'includes': [ 'generate_manifest.gypi', ],
+ },
],
}

Powered by Google App Engine
This is Rietveld 408576698