Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4062)

Unified Diff: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

Issue 295123002: Provide script/gypi support for manifest generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Support Jinja2. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
diff --git a/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..40c64cb70cc6c20d472bba33922a3de224163116
--- /dev/null
+++ b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
@@ -0,0 +1,35 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Generates an output manifest based on a Jinja2 templated manifest.
Peter Lundblad 2014/05/23 16:04:27 nit: s/an output/a/
Peter Lundblad 2014/05/23 16:04:27 nit: mention that this is expected to be included
David Tseng 2014/05/23 19:16:37 Done.
David Tseng 2014/05/23 19:16:37 I don't claim to be a grammar wiz, but greping for
+# The following variables must be set before including this file:
+#
+# template_manifest: a valid JSON file path.
Peter Lundblad 2014/05/23 16:04:27 nit: it's a path to a jinja2 file.
Peter Lundblad 2014/05/23 16:04:27 Usually file name variable end in -Ifle and _path
David Tseng 2014/05/23 19:16:37 Done.
+# output_manifest: file path with the resulting manifest.
Peter Lundblad 2014/05/23 16:04:27 s/with/for?
David Tseng 2014/05/23 19:16:37 Sure; why not.
+
+{
+ 'actions': [
+ {
+ 'action_name': 'generate_manifest',
+ 'message': 'Generate manifest for <(_target_name)',
+ 'variables': {
+ 'is_guest_manifest%': 0,
+ },
+ 'inputs': [
+ 'tools/generate_manifest.py',
+ '<(template_manifest)',
+ ],
+ 'outputs': [
+ '<(output_manifest)'
+ ],
+ 'action': [
+ 'python',
+ 'tools/generate_manifest.py',
+ '-o', '<(output_manifest)',
+ '-g', '<(is_guest_manifest)',
+ '<(template_manifest)'
+ ],
+ },
+ ],
+}

Powered by Google App Engine
This is Rietveld 408576698