Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(558)

Issue 2951213004: [MD-Settings][Night Light] String and font changes requests (Closed)

Created:
2 years, 11 months ago by afakhry
Modified:
2 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD-Settings][Night Light] String and font changes requests Implement the last minute font and string changes request.\ Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=735253#c4 BUG=735253 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2951213004 Cr-Commit-Position: refs/heads/master@{#481943} Committed: https://chromium.googlesource.com/chromium/src/+/c10d06ba6f32eb0e51ba8a76c1c09b6d292c1cf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/device_page/night_light_slider.html View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
afakhry
Steven, yet another Night Light change. :( Please take a look. Thanks.
2 years, 11 months ago (2017-06-22 23:14:35 UTC) #3
stevenjb
lgtm
2 years, 11 months ago (2017-06-23 00:10:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951213004/1
2 years, 11 months ago (2017-06-23 16:11:33 UTC) #6
commit-bot: I haz the power
2 years, 11 months ago (2017-06-23 17:28:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c10d06ba6f32eb0e51ba8a76c1c0...

Powered by Google App Engine
This is Rietveld 408576698