Issue 2951193006: [iOS] Vertically center subviews in the Keyboard Accessory View and remove button background

Issue 2951193006: [iOS] Vertically center subviews in the Keyboard Accessory View and remove button background (Closed)

Created:
3 years, 6 months ago by jif

Modified:
3 years, 5 months ago

Reviewers:
jif-google, justincohen

CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

[iOS] Vertically center subviews in the Keyboard Accessory View and remove button background BUG=736409 Review-Url: https://codereview.chromium.org/2951193006 Cr-Commit-Position: refs/heads/master@{#482618} Committed: https://chromium.googlesource.com/chromium/src/+/0c062aa92c26aad33f661601b1eb86b5b5c236e8

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -27 lines)			Patch
M	ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm	View	1	5 chunks	+21 lines, -27 lines	0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.png	View	1 2	Binary file		0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner@2x.png	View	1 2	Binary file		0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner@3x.png	View	1 2	Binary file		0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.png	View	1 2	Binary file		0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search@2x.png	View	1 2	Binary file		0 comments	Download
M	ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search@3x.png	View	1 2	Binary file		0 comments	Download

Total messages: 15 (9 generated)

jif

what it looks like: https://drive.google.com/file/d/0B_beYZEcAMtDUkxnLUQwdmNCNjg/view?usp=sharing

3 years, 6 months ago (2017-06-23 17:01:23 UTC) #5

jif

what it looks like: https://drive.google.com/file/d/0B_beYZEcAMtDUkxnLUQwdmNCNjg/view?usp=sharing

3 years, 6 months ago (2017-06-23 17:01:24 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2951193006/60001

3 years, 5 months ago (2017-06-27 14:04:15 UTC) #12

commit-bot: I haz the power

3 years, 5 months ago (2017-06-27 14:16:43 UTC) #15

Message was sent while issue was closed.

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0c062aa92c26aad33f661601b1eb...