Issue 295103014: Build official release builds on Mac with ASAN. Not for check-in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295103014: Build official release builds on Mac with ASAN. Not for check-in (Closed)

Created:
6 years, 7 months ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build official release builds on Mac with ASAN. Not for check-in. Abandoned

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -21 lines)			Patch
M	build/asan.saves	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	build/common.gypi	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

To avoid accidental checkin on trunk: not LGTM This change is only intended to be ...

6 years, 7 months ago (2014-05-23 21:07:02 UTC) #1

Alexander Potapenko

On 2014/05/23 21:07:16, Mark Mentovai wrote: > Not LGTM Does ASAN_OPTIONS=replace_intrin=0 solve the problem with ...

6 years, 7 months ago (2014-05-27 07:32:29 UTC) #3

Mark Mentovai

Yes, that does fix it. I tried looking for documentation on what replace_intrin actually does, ...

6 years, 7 months ago (2014-05-27 12:52:26 UTC) #4

Alexander Potapenko

6 years, 6 months ago (2014-06-04 08:04:27 UTC) #5

On 2014/05/27 12:52:26, Mark Mentovai wrote:
> Yes, that does fix it.
> 
> I tried looking for documentation on what replace_intrin actually does, but
> didn’t find anything. What are the drawbacks?

This flag disables the addressability checks in memset/memcpy/memmove calls, so
we may miss some errors.

Expand Messages | Collapse Messages