Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3675)

Unified Diff: build/common.gypi

Issue 295103014: Build official release builds on Mac with ASAN. Not for check-in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/asan.saves ('k') | ppapi/native_client/src/trusted/plugin/plugin.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index bb72124c887627b1c76ec4eb1479dff530d6cb0a..edb9d7e7e85d88bc725f682c3d3f815b0107cfee 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -566,6 +566,10 @@
'ozone_auto_platforms%': 1,
'conditions': [
+ ['OS=="mac" and buildtype=="Official" and branding=="Chrome"', {
+ 'asan%': 1,
+ }],
+
# A flag for POSIX platforms
['OS=="win"', {
'os_posix%': 0,
@@ -2005,11 +2009,6 @@
'clang%': 1,
'use_allocator%': 'none',
}],
- ['asan==1 and OS=="mac"', {
- # TODO(glider): we do not strip ASan binaries until the dynamic ASan
- # runtime is fully adopted. See http://crbug.com/242503.
- 'mac_strip_release': 0,
- }],
['lsan==1', {
'clang%': 1,
}],
« no previous file with comments | « build/asan.saves ('k') | ppapi/native_client/src/trusted/plugin/plugin.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698