[Mac] Dismiss the first run bubble when the user starts typing.

[Mac] Dismiss the first run bubble when the user starts typing.

The "You can search from here with Google" first run bubble is a child
window of the browser window, and is made key because it contains a
button (so you can press the button via accessibility). All of this is
fine, except the omnibox is the browser window's first responder and
displays a focus ring. So, to the user it looks like they can start
typing (and indeed, the bubble invites them to "Type to search or
enter a URL to navigate...."), but the bubble consumes all key events.
This is a jarring experience for a first-time Chrome Mac user.

This cl changes the first run bubble to dismiss itself when the user
starts typing.

R=avi@chromium.org
BUG=657592
Review-Url: https://codereview.chromium.org/2951013002
Cr-Commit-Position: refs/heads/master@{#481073}
Committed: https://chromium.googlesource.com/chromium/src/+/96db21c3f062509bb04eb8b2c505acf96326eb36

[shrike, 2017-06-21 00:26:51]

PTAL

[Avi (use Gerrit), 2017-06-21 00:32:44]

LGTM

This doesn't interfere with the use of Accessibility to activate the button?

[shrike, 2017-06-21 00:38:11]

On 2017/06/21 00:32:44, Avi (ping after 24h) wrote:
> LGTM
> 
> This doesn't interfere with the use of Accessibility to activate the button?

No, that still works as it did before.

[shrike, 2017-06-21 00:38:34]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2017-06-21 00:38:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 01:43:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498005514341680, "parent_rev":
"820778c575fe891e178b0671a92817a2e54ba197", "commit_rev":
"965d30b0a136e843c21948fa7078de69c8f88da5"}

[commit-bot: I haz the power, 2017-06-21 01:43:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498005514341680, "parent_rev":
"f5564492acab112b1620ad499ffa267fa231a23d", "commit_rev":
"36df63900477bace04c50e2b2070c1f18d99982b"}

[commit-bot: I haz the power, 2017-06-21 01:44:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498005514341680, "parent_rev":
"738636e60050e63820dfcd90e722b909d9c1dbac", "commit_rev":
"96db21c3f062509bb04eb8b2c505acf96326eb36"}

[commit-bot: I haz the power, 2017-06-21 01:44:23]

Description was changed from

==========
[Mac] Dismiss the first run bubble when the user starts typing.

The "You can search from here with Google" first run bubble is a child
window of the browser window, and is made key because it contains a
button (so you can press the button via accessibility). All of this is
fine, except the omnibox is the browser window's first responder and
displays a focus ring. So, to the user it looks like they can start
typing (and indeed, the bubble invites them to "Type to search or
enter a URL to navigate...."), but the bubble consumes all key events.
This is a jarring experience for a first-time Chrome Mac user.

This cl changes the first run bubble to dismiss itself when the user
starts typing.

R=avi@chromium.org
BUG=657592
==========

to

==========
[Mac] Dismiss the first run bubble when the user starts typing.

The "You can search from here with Google" first run bubble is a child
window of the browser window, and is made key because it contains a
button (so you can press the button via accessibility). All of this is
fine, except the omnibox is the browser window's first responder and
displays a focus ring. So, to the user it looks like they can start
typing (and indeed, the bubble invites them to "Type to search or
enter a URL to navigate...."), but the bubble consumes all key events.
This is a jarring experience for a first-time Chrome Mac user.

This cl changes the first run bubble to dismiss itself when the user
starts typing.

R=avi@chromium.org
BUG=657592

Review-Url: https://codereview.chromium.org/2951013002
Cr-Commit-Position: refs/heads/master@{#481073}
Committed:
https://chromium.googlesource.com/chromium/src/+/96db21c3f062509bb04eb8b2c505...
==========

[commit-bot: I haz the power, 2017-06-21 01:44:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96db21c3f062509bb04eb8b2c505...