Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2950993003: [Chromoting] Use ProcessStatsSender in DaemonProcess (daemon process) (Closed)

Created:
3 years, 6 months ago by Hzj_jie
Modified:
3 years, 5 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org, Jamie, Sergey Ulanov
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use ProcessStatsSender in DaemonProcess (daemon process) This is a copy & paste from DesktopSessionAgent (https://codereview.chromium.org/2933203002/) to DaemonProcess to allow daemon process to report process statistics data to network process. BUG=650926 Review-Url: https://codereview.chromium.org/2950993003 Cr-Commit-Position: refs/heads/master@{#483539} Committed: https://chromium.googlesource.com/chromium/src/+/dda3acb809c43e2d633c335778ff4a1522927e59

Patch Set 1 #

Total comments: 4

Patch Set 2 : Stop process stats when network process crashes #

Total comments: 16

Patch Set 3 : Resolve review comments #

Patch Set 4 : Resolve review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -2 lines) Patch
M remoting/host/daemon_process.h View 1 2 3 6 chunks +32 lines, -1 line 0 comments Download
M remoting/host/daemon_process.cc View 1 2 3 7 chunks +47 lines, -0 lines 0 comments Download
M remoting/host/daemon_process_unittest.cc View 1 2 3 2 chunks +55 lines, -1 line 0 comments Download
M remoting/host/desktop_session_win.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/process_stats_sender.h View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/host/process_stats_sender.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M remoting/host/win/worker_process_launcher.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 1 2 3 8 chunks +15 lines, -0 lines 0 comments Download
M remoting/host/worker_process_ipc_delegate.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 48 (34 generated)
Hzj_jie
3 years, 6 months ago (2017-06-21 01:30:51 UTC) #5
joedow
https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h#newcode207 remoting/host/daemon_process.h:207: // Daemon and Network processes manages multiple desktop sessions. ...
3 years, 6 months ago (2017-06-21 15:30:50 UTC) #8
joedow
https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h#newcode207 remoting/host/daemon_process.h:207: // Daemon and Network processes manages multiple desktop sessions. ...
3 years, 6 months ago (2017-06-21 15:32:04 UTC) #9
Hzj_jie
https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h#newcode207 remoting/host/daemon_process.h:207: // Daemon and Network processes manages multiple desktop sessions. ...
3 years, 6 months ago (2017-06-21 21:42:56 UTC) #22
joedow
https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h#newcode207 remoting/host/daemon_process.h:207: // Daemon and Network processes manages multiple desktop sessions. ...
3 years, 6 months ago (2017-06-21 22:00:20 UTC) #23
Hzj_jie
On 2017/06/21 22:00:20, joedow wrote: > https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h > File remoting/host/daemon_process.h (right): > > https://codereview.chromium.org/2950993003/diff/1/remoting/host/daemon_process.h#newcode207 > ...
3 years, 6 months ago (2017-06-21 23:53:59 UTC) #24
joedow
A few comments on this approach if you decide not to go the centralized monitor ...
3 years, 6 months ago (2017-06-23 18:03:08 UTC) #25
Hzj_jie
I think it's still reasonable to use this solution before finishing the investigation of other ...
3 years, 6 months ago (2017-06-24 00:51:41 UTC) #30
Hzj_jie
On 2017/06/24 00:51:41, Hzj_jie wrote: > I think it's still reasonable to use this solution ...
3 years, 5 months ago (2017-06-29 00:17:07 UTC) #31
joedow
https://codereview.chromium.org/2950993003/diff/60001/remoting/host/daemon_process.cc File remoting/host/daemon_process.cc (right): https://codereview.chromium.org/2950993003/diff/60001/remoting/host/daemon_process.cc#newcode148 remoting/host/daemon_process.cc:148: void DaemonProcess::OnWorkerProcessStopped(int exit_code) { On 2017/06/24 00:51:40, Hzj_jie wrote: ...
3 years, 5 months ago (2017-06-29 17:24:03 UTC) #32
Hzj_jie
https://codereview.chromium.org/2950993003/diff/60001/remoting/host/daemon_process.cc File remoting/host/daemon_process.cc (right): https://codereview.chromium.org/2950993003/diff/60001/remoting/host/daemon_process.cc#newcode148 remoting/host/daemon_process.cc:148: void DaemonProcess::OnWorkerProcessStopped(int exit_code) { On 2017/06/29 17:24:03, joedow wrote: ...
3 years, 5 months ago (2017-06-29 20:24:57 UTC) #42
joedow
lgtm
3 years, 5 months ago (2017-06-29 20:30:17 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950993003/120001
3 years, 5 months ago (2017-06-29 23:14:07 UTC) #45
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 23:19:36 UTC) #48
Message was sent while issue was closed.
Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/dda3acb809c43e2d633c335778ff...

Powered by Google App Engine
This is Rietveld 408576698