Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

BUG=561800
Review-Url: https://codereview.chromium.org/2950803002
Cr-Commit-Position: refs/heads/master@{#481476}
Committed: https://chromium.googlesource.com/chromium/src/+/3e097a99d8e07eed0197a0ff856e0e8cb988766b

[Tripta, 2017-06-20 12:19:07]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

BUG=561800
==========

[Tripta, 2017-06-20 12:19:07]

tripta.g@samsung.com changed reviewers:
+ thakis@chromium.org

[Tripta, 2017-06-20 12:19:55]

Hi thakis,

Please review code changes for below files:

  chrome/browser/android/offline_pages/offline_page_utils.cc
  chrome/browser/android/preferences/website_preference_bridge.cc
  chrome/browser/android/thumbnail/thumbnail_cache.cc
  chrome/browser/autofill/autofill_browsertest.cc
  chrome/browser/browsing_data/browsing_data_helper.cc
  chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm
  chrome/browser/plugins/plugin_metadata.cc
  chrome/browser/prerender/prerender_contents.cc
  chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
 
chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc
  chrome/browser/safe_browsing/local_database_manager.cc
  chrome/test/chromedriver/server/chromedriver_server.cc

Regards
Tripta

[Nico, 2017-06-20 15:05:07]

lgtm

https://codereview.chromium.org/2950803002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc (right):

https://codereview.chromium.org/2950803002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc:600:
EXPECT_TRUE(!base::ContainsValue(urls, prefetched_url));
EXPECT_FALSE(Contains) instead of EXPECT_TRUE(!Contains)

[Tripta, 2017-06-22 05:04:31]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-22 05:04:32]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2950803002/#ps20001
(title: "Changed EXPECT_TRUE to EXPECT_FALSE")

[commit-bot: I haz the power, 2017-06-22 05:04:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 05:23:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 05:23:17]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Tripta, 2017-06-22 06:45:07]

The CQ bit was checked by tripta.g@samsung.com

[Tripta, 2017-06-22 06:45:08]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2950803002/#ps40001
(title: "Reverted code for file thumbnail_cache.cc")

[commit-bot: I haz the power, 2017-06-22 06:45:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tripta, 2017-06-22 07:01:19]

Hi thakis,

Have made the changes. Please check.

Regards
Tripta

https://codereview.chromium.org/2950803002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc (right):

https://codereview.chromium.org/2950803002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc:600:
EXPECT_TRUE(!base::ContainsValue(urls, prefetched_url));
On 2017/06/20 15:05:07, Nico wrote:
> EXPECT_FALSE(Contains) instead of EXPECT_TRUE(!Contains)

Done.

[commit-bot: I haz the power, 2017-06-22 07:56:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498113907951410,
"parent_rev": "3257715cb4876e1917ac2464d326ca3437bc7c9b", "commit_rev":
"3e097a99d8e07eed0197a0ff856e0e8cb988766b"}

[commit-bot: I haz the power, 2017-06-22 07:56:41]

Description was changed from

==========
Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

BUG=561800
==========

to

==========
Use ContainsValue() instead of std::find() in chrome/browser/ and chrome/test/

BUG=561800

Review-Url: https://codereview.chromium.org/2950803002
Cr-Commit-Position: refs/heads/master@{#481476}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e097a99d8e07eed0197a0ff856e...
==========

[commit-bot: I haz the power, 2017-06-22 07:56:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e097a99d8e07eed0197a0ff856e...