Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2950793002: Move drag related functions present in LocalFrame.cpp to correct files. (Closed)

Created:
3 years, 6 months ago by tanvir
Modified:
3 years, 6 months ago
Reviewers:
tkent, Srirama, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move drag related functions present in LocalFrame.cpp to correct files. Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(), DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame() to DataTransfer.cpp. Move DragController::DragImageForSelection() to DragController.cpp. BUG=727981 Review-Url: https://codereview.chromium.org/2950793002 Cr-Commit-Position: refs/heads/master@{#481067} Committed: https://chromium.googlesource.com/chromium/src/+/ee841c26ab77ca0aebd65ad839167b2178b7ecde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -189 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 3 chunks +150 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 4 chunks +0 lines, -188 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tanvir
PTAL!!! Thanks
3 years, 6 months ago (2017-06-20 12:38:09 UTC) #8
Xiaocheng
lgtm. Thanks!
3 years, 6 months ago (2017-06-20 17:59:06 UTC) #10
tkent
lgtm
3 years, 6 months ago (2017-06-20 23:00:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950793002/1
3 years, 6 months ago (2017-06-21 01:35:39 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 01:42:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee841c26ab77ca0aebd65ad83916...

Powered by Google App Engine
This is Rietveld 408576698