[turbofan] Introduce new JSCallWithArrayLike operator.

[turbofan] Introduce new JSCallWithArrayLike operator.

Add a new JSCallWithArrayLike operator that is backed by the
CallWithArrayLike builtin, and use that operator for both
Function.prototype.apply and Reflect.apply inlining. Also unify
the handling of JSCallWithArrayLike and JSCallWithSpread in
the JSCallReducer to reduce the copy&paste overhead.

Drive-by-fix: Add a lot of test coverage for Reflect.apply and
Function.prototype.apply in optimized code, especially for some
corner cases, which was missing so far.

BUG=v8:4587, v8:5269
R=petermarshall@chromium.org

Review-Url: https://codereview.chromium.org/2950773002
Cr-Commit-Position: refs/heads/master@{#46041}
Committed: https://chromium.googlesource.com/v8/v8/+/767ce7887130ce47ada53e23682e44637c6ef301

[Benedikt Meurer, 2017-06-20 08:46:55]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 08:47:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 09:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 09:14:02]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-06-20 11:51:11]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 11:51:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 12:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 12:19:08]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2017-06-20 12:21:57]

LGTM with one comment, thanks

https://codereview.chromium.org/2950773002/diff/1/src/compiler/js-call-reduce...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2950773002/diff/1/src/compiler/js-call-reduce...
src/compiler/js-call-reducer.cc:728: node->opcode() ==
IrOpcode::kJSConstructWithSpread) {
Maybe you could pull this condition into a boolean variable at the top of the
function because it gets repeated a fair few times.

[Benedikt Meurer, 2017-06-20 12:34:41]

https://codereview.chromium.org/2950773002/diff/1/src/compiler/js-call-reduce...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2950773002/diff/1/src/compiler/js-call-reduce...
src/compiler/js-call-reducer.cc:728: node->opcode() ==
IrOpcode::kJSConstructWithSpread) {
I thought about it, but decided against it, b/c

(a) this whole code needs to be split into two parts anyways once JSCallVarargs
is in, and
(b) it's less explicit and booleans tend to go out of sync.

[Benedikt Meurer, 2017-06-20 12:34:48]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-06-20 12:34:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 12:36:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497962088259740,
"parent_rev": "d00b37fb1902b6437bdd45ce714e19d2f45e53b7", "commit_rev":
"767ce7887130ce47ada53e23682e44637c6ef301"}

[commit-bot: I haz the power, 2017-06-20 12:36:51]

Description was changed from

==========
[turbofan] Introduce new JSCallWithArrayLike operator.

Add a new JSCallWithArrayLike operator that is backed by the
CallWithArrayLike builtin, and use that operator for both
Function.prototype.apply and Reflect.apply inlining. Also unify
the handling of JSCallWithArrayLike and JSCallWithSpread in
the JSCallReducer to reduce the copy&paste overhead.

Drive-by-fix: Add a lot of test coverage for Reflect.apply and
Function.prototype.apply in optimized code, especially for some
corner cases, which was missing so far.

BUG=v8:4587,v8:5269
R=petermarshall@chromium.org
==========

to

==========
[turbofan] Introduce new JSCallWithArrayLike operator.

Add a new JSCallWithArrayLike operator that is backed by the
CallWithArrayLike builtin, and use that operator for both
Function.prototype.apply and Reflect.apply inlining. Also unify
the handling of JSCallWithArrayLike and JSCallWithSpread in
the JSCallReducer to reduce the copy&paste overhead.

Drive-by-fix: Add a lot of test coverage for Reflect.apply and
Function.prototype.apply in optimized code, especially for some
corner cases, which was missing so far.

BUG=v8:4587,v8:5269
R=petermarshall@chromium.org

Review-Url: https://codereview.chromium.org/2950773002
Cr-Commit-Position: refs/heads/master@{#46041}
Committed:
https://chromium.googlesource.com/v8/v8/+/767ce7887130ce47ada53e23682e44637c6...
==========

[commit-bot: I haz the power, 2017-06-20 12:36:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/767ce7887130ce47ada53e23682e44637c6...