Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2950763002:
Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() (Closed)
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition()
This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving
code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing
const-variable for improving readability.
Note: The diff could be small but changing indentation makes diff larger.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2950763002
Cr-Commit-Position: refs/heads/master@{#481056}
Committed: https://chromium.googlesource.com/chromium/src/+/59326d74274f028a233a2561f940a84675e0c967
Patch Set 1 : 2017-06-20T16:14:05 #Patch Set 2 : 2017-06-20T18:53:06 rebase for win_clang bot #
Messages
Total messages: 20 (15 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-20T16:09:38 BUG=707656 2017-06-20T16:09:14 ========== to ========== Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. BUG=707656 TEST=n/a; no behavior changes ==========
Description was changed from ========== Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. Note: The diff could be small but changing indentation makes diff larger. BUG=707656 TEST=n/a; no behavior changes ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
Btw, you once used the trick that adds extra scopes to keep the original indentation, so that diff is still small. I think we can use this trick in the future.
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498007221103450,
"parent_rev": "b57b5b36e33de7d15c06615156e00a45c79a4c13", "commit_rev":
"59326d74274f028a233a2561f940a84675e0c967"}
Message was sent while issue was closed.
Description was changed from ========== Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. Note: The diff could be small but changing indentation makes diff larger. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Introduce AdjustInlineBoxPositionForPrimaryDirection() for ComputeInlineBoxPosition() This patch introduces |AdjustInlineBoxPositionForPrimaryDirection()| by moving code from then-clause of |AdjustInlineBoxPositionForTextNode()| with utilizing const-variable for improving readability. Note: The diff could be small but changing indentation makes diff larger. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2950763002 Cr-Commit-Position: refs/heads/master@{#481056} Committed: https://chromium.googlesource.com/chromium/src/+/59326d74274f028a233a2561f940... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/59326d74274f028a233a2561f940... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
