Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2950553003: Tune tap disambiguation triggering threshold. (Closed)

Created:
3 years, 6 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 6 months ago
Reviewers:
bokan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tune tap disambiguation triggering threshold. UMA data shows that users disambiguate to the touch adjustment preferred node twice as often as the next best candidate. This shows the disambiguation feature is overtriggering -- ideally, the probability would be equal. There is already logic to throw out candidates if their overlap area is strongly outweighed by the best candidate. This uses an arbitrary ratio of 50%. Increasing it to 75% doesn't visibly undertrigger when I expect it to on desktop NYTimes sidebars on my Nexus 6P, so try that threshold to improve the stats. BUG=704323 Review-Url: https://codereview.chromium.org/2950553003 Cr-Commit-Position: refs/heads/master@{#480916} Committed: https://chromium.googlesource.com/chromium/src/+/aca7a78d0cf36f18816de26361a34f0d0b9c7e6c

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -33 lines) Patch
M third_party/WebKit/Source/core/page/TouchDisambiguation.cpp View 1 1 chunk +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 20 chunks +48 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
aelias_OOO_until_Jul13
Hi bokan@, PTAL.
3 years, 6 months ago (2017-06-20 01:10:10 UTC) #8
bokan
lgtm
3 years, 6 months ago (2017-06-20 15:10:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950553003/20001
3 years, 6 months ago (2017-06-20 19:46:32 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 19:54:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aca7a78d0cf36f18816de26361a3...

Powered by Google App Engine
This is Rietveld 408576698