Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2950523003: [Mac] Fix for Dialog Textfields (Closed)

Created:
3 years, 6 months ago by spqchan
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/branch-heads/3135
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for Dialog Textfields Currently, the custom field editors in the BookmarkBubbleController and BookmarkEditorController are causing incorrect behaviors with the dialog textfields. Also, a zombie crash is still happening. To fix the behavior, don't shift the custom field editors to the autorelease pool and force the editors to resign the first responder. Bug: 731284 Change-Id: I23ab024c9b5de2d8ddb6d654de676d3039c7f406 Reviewed-on: https://chromium-review.googlesource.com/538954 Reviewed-by: Robert Sesek <rsesek@chromium.org>; Commit-Queue: Sarah Chan <spqchan@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#480512} Review-Url: https://codereview.chromium.org/2950523003 . Cr-Commit-Position: refs/branch-heads/3135@{#4} Cr-Branched-From: a990af190304be5bf38b120799c594df5a293518-refs/heads/master@{#480321} Committed: https://chromium.googlesource.com/chromium/src/+/f8f848011e387562d9e9f39f6d4899f7805d9f9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.mm View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
spqchan
3 years, 6 months ago (2017-06-19 20:03:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8f848011e387562d9e9f39f6d4899f7805d9f9d.

Powered by Google App Engine
This is Rietveld 408576698