Revert "Redirects _blank and window.open() off-origin navigation from PWA to CCT."

Revert "Redirects _blank and window.open() off-origin navigation from PWA to CCT."

This reverts commit 4d9776c156c177107053872a437a9639d95a7160.

Reason for revert: This caused each of the following tests:

WebappNavigationTest#testNewTabLinkOpensInCct,
WebappNavigationTest#testRegularLinkOffOriginInCctNoWebappThemeColor,
WebappNavigationTest#testWindowOpenInCct and
WebappNavigationTest#testWindowTopLocationOffOriginInCctAndWebappThemeColor

to fail consistently on one or more of the following bots:

http://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester
http://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester
http://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester
http://build.chromium.org/p/chromium.swarm/builders/Android%20N5X%20Swarm

and the first test also fails flakily on Lollipop Phone Tester and
Marshmallow 64 bit Tester.

Original change's description:
> Redirects _blank and window.open() off-origin navigation from PWA to CCT.
>
> Custom Tab opened from a _blank link or a window.open() call is opened in
> a separate Android task to mimic a new window/blank context of a web browser.
> This is done in order to improve UX and bring more app-like feel to PWAs.
> Transition to CCT for regular navigation is already done
> (codereview.chromium.org/2829943002), this patch brings the same to _blank
> and window.open().
>
> This requires some changes to Custom Tabs, as WebContents for the new window
> is already created when we get to Java layer. I replicated the trick from
> ChromeTabCreator with remembering WebContents on AsyncTabParamsManager
> during the transition.
>
> Tests asserting that _blank and window.open() are opened in TabbedChrome has
> been removed from WebappModeTest. Tests for transition to CCT has been added
> to WebappNavigationTest.
>
> On Lollipop and above we maintain at most one CCT task per installed Webapp.
> Below Lollipop there is no API I could use to enforce that I think, let me
> know if you know the way.
>
> BUG=709889
> Review-Url: https://codereview.chromium.org/2898373002
> Cr-Commit-Position: refs/heads/master@{#480286}

BUG=709889
TBR=piotrs@chromium.org,yusufo@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2950483002
Cr-Commit-Position: refs/heads/master@{#480393}
Committed: https://chromium.googlesource.com/chromium/src/+/f07b85c1f7fe540b0b900f8969d5ac6d9e42a892

[johnme, 2017-06-19 10:40:55]

The CQ bit was checked by johnme@chromium.org

[commit-bot: I haz the power, 2017-06-19 10:41:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 10:46:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497868855164650, "parent_rev":
"c9cb177ab255f3978bcb203f0c0867d7eed1a80d", "commit_rev":
"f07b85c1f7fe540b0b900f8969d5ac6d9e42a892"}

[commit-bot: I haz the power, 2017-06-19 10:46:38]

Description was changed from

==========
Revert "Redirects _blank and window.open() off-origin navigation from PWA to
CCT."

This reverts commit 4d9776c156c177107053872a437a9639d95a7160.

Reason for revert: This caused each of the following tests:

WebappNavigationTest#testNewTabLinkOpensInCct,
WebappNavigationTest#testRegularLinkOffOriginInCctNoWebappThemeColor,
WebappNavigationTest#testWindowOpenInCct and
WebappNavigationTest#testWindowTopLocationOffOriginInCctAndWebappThemeColor

to fail consistently on one or more of the following bots:

http://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester
http://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester
http://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%...
http://build.chromium.org/p/chromium.swarm/builders/Android%20N5X%20Swarm

and the first test also fails flakily on Lollipop Phone Tester and
Marshmallow 64 bit Tester.

Original change's description:
> Redirects _blank and window.open() off-origin navigation from PWA to CCT.
>
> Custom Tab opened from a _blank link or a window.open() call is opened in
> a separate Android task to mimic a new window/blank context of a web browser.
> This is done in order to improve UX and bring more app-like feel to PWAs.
> Transition to CCT for regular navigation is already done
> (codereview.chromium.org/2829943002), this patch brings the same to _blank
> and window.open().
>
> This requires some changes to Custom Tabs, as WebContents for the new window
> is already created when we get to Java layer. I replicated the trick from
> ChromeTabCreator with remembering WebContents on AsyncTabParamsManager
> during the transition.
>
> Tests asserting that _blank and window.open() are opened in TabbedChrome has
> been removed from WebappModeTest. Tests for transition to CCT has been added
> to WebappNavigationTest.
>
> On Lollipop and above we maintain at most one CCT task per installed Webapp.
> Below Lollipop there is no API I could use to enforce that I think, let me
> know if you know the way.
>
> BUG=709889
> Review-Url: https://codereview.chromium.org/2898373002
> Cr-Commit-Position: refs/heads/master@{#480286}

BUG=709889
TBR=piotrs@chromium.org,yusufo@chromium.org
NOTRY=true
NOTREECHECKS=true
==========

to

==========
Revert "Redirects _blank and window.open() off-origin navigation from PWA to
CCT."

This reverts commit 4d9776c156c177107053872a437a9639d95a7160.

Reason for revert: This caused each of the following tests:

WebappNavigationTest#testNewTabLinkOpensInCct,
WebappNavigationTest#testRegularLinkOffOriginInCctNoWebappThemeColor,
WebappNavigationTest#testWindowOpenInCct and
WebappNavigationTest#testWindowTopLocationOffOriginInCctAndWebappThemeColor

to fail consistently on one or more of the following bots:

http://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester
http://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester
http://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%...
http://build.chromium.org/p/chromium.swarm/builders/Android%20N5X%20Swarm

and the first test also fails flakily on Lollipop Phone Tester and
Marshmallow 64 bit Tester.

Original change's description:
> Redirects _blank and window.open() off-origin navigation from PWA to CCT.
>
> Custom Tab opened from a _blank link or a window.open() call is opened in
> a separate Android task to mimic a new window/blank context of a web browser.
> This is done in order to improve UX and bring more app-like feel to PWAs.
> Transition to CCT for regular navigation is already done
> (codereview.chromium.org/2829943002), this patch brings the same to _blank
> and window.open().
>
> This requires some changes to Custom Tabs, as WebContents for the new window
> is already created when we get to Java layer. I replicated the trick from
> ChromeTabCreator with remembering WebContents on AsyncTabParamsManager
> during the transition.
>
> Tests asserting that _blank and window.open() are opened in TabbedChrome has
> been removed from WebappModeTest. Tests for transition to CCT has been added
> to WebappNavigationTest.
>
> On Lollipop and above we maintain at most one CCT task per installed Webapp.
> Below Lollipop there is no API I could use to enforce that I think, let me
> know if you know the way.
>
> BUG=709889
> Review-Url: https://codereview.chromium.org/2898373002
> Cr-Commit-Position: refs/heads/master@{#480286}

BUG=709889
TBR=piotrs@chromium.org,yusufo@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2950483002
Cr-Commit-Position: refs/heads/master@{#480393}
Committed:
https://chromium.googlesource.com/chromium/src/+/f07b85c1f7fe540b0b900f8969d5...
==========

[commit-bot: I haz the power, 2017-06-19 10:46:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f07b85c1f7fe540b0b900f8969d5...