Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2950473003: Omnibox Test: Fix noisy mock in OmniboxEditTests (Closed)

Created:
3 years, 6 months ago by tommycli
Modified:
3 years, 6 months ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox Test: Fix noisy mock in OmniboxEditTests BUG=647279 Review-Url: https://codereview.chromium.org/2950473003 Cr-Commit-Position: refs/heads/master@{#480841} Committed: https://chromium.googlesource.com/chromium/src/+/c4321b3b2bacacc417420219d2d8cfc1895792a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/omnibox/browser/omnibox_edit_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tommycli
PTAL. Suppresses "uninteresting call" gmock logs per recommendations here: https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#ignoring-uninteresting-calls
3 years, 6 months ago (2017-06-20 01:00:48 UTC) #3
Justin Donnelly
lgtm On 2017/06/20 01:00:48, tommycli wrote: > PTAL. Suppresses "uninteresting call" gmock logs per recommendations ...
3 years, 6 months ago (2017-06-20 15:23:01 UTC) #7
tommycli
cool thanks
3 years, 6 months ago (2017-06-20 16:07:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950473003/1
3 years, 6 months ago (2017-06-20 16:07:20 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 16:12:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4321b3b2bacacc417420219d2d8...

Powered by Google App Engine
This is Rietveld 408576698