Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2950423002: Remove WebGL2 constraint that requires draw*Instanced() calls to fail when no vertex attrib has zer… (Closed)

Created:
3 years, 6 months ago by Zhenyao Mo
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Corentin Wallez, Geoff Lang
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebGL2 constraint that requires draw*Instanced() calls to fail when no vertex attrib has zero divisor. BUG=736070 TEST=https://github.com/KhronosGroup/WebGL/pull/2424 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2950423002 Cr-Commit-Position: refs/heads/master@{#481973} Committed: https://chromium.googlesource.com/chromium/src/+/279ae138790e2ba909d0229c1e429ffffda8578f

Patch Set 1 #

Patch Set 2 : one more entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 chunks +9 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Zhenyao Mo
kbr: PTAL Others: FYI
3 years, 6 months ago (2017-06-22 20:28:31 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Geoff mentioned that an ANGLE roll will also be needed in order to pass ...
3 years, 6 months ago (2017-06-22 20:36:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950423002/1
3 years, 6 months ago (2017-06-22 21:08:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/11619)
3 years, 6 months ago (2017-06-22 22:05:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950423002/20001
3 years, 6 months ago (2017-06-23 17:26:02 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 18:52:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/279ae138790e2ba909d0229c1e42...

Powered by Google App Engine
This is Rietveld 408576698