Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/nibs/MainMenu.xib

Issue 2950403002: [Mac] Add system share menu
Patch Set: Guard against empty web contents Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/app_controller_mac.h » ('j') | chrome/browser/app_controller_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/nibs/MainMenu.xib
diff --git a/chrome/app/nibs/MainMenu.xib b/chrome/app/nibs/MainMenu.xib
index 564ed8fd8b52a31bef2cee8e4c4a2f4b31d47cd3..51384d4e5a7a0e54c622e103b88dafc16777761d 100644
--- a/chrome/app/nibs/MainMenu.xib
+++ b/chrome/app/nibs/MainMenu.xib
@@ -139,10 +139,12 @@ CA
</connections>
</menuItem>
<menuItem isSeparatorItem="YES" id="452"/>
- <menuItem title="^IDS_EMAIL_PAGE_LOCATION_MAC" tag="35006" keyEquivalent="I" id="451">
- <connections>
- <action selector="commandDispatch:" target="-1" id="668"/>
- </connections>
+ <menuItem title="Share" id="L1I-I9-Q7f">
+ <modifierMask key="keyEquivalentModifierMask"/>
+ <menu key="submenu" title="Share" id="T9x-6Q-SHx">
Robert Sesek 2017/06/28 15:37:54 Should the title be ^IDS_SHARE_MAC ?
lgrey 2017/06/29 21:11:49 Done.
+ <items>
+ </items>
+ </menu>
</menuItem>
<menuItem isSeparatorItem="YES" id="74"/>
<menuItem title="^IDS_PRINT" tag="35003" keyEquivalent="p" id="78">
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/app_controller_mac.h » ('j') | chrome/browser/app_controller_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698