Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/app/nibs/MainMenu.xib

Issue 2950403002: [Mac] Add system share menu
Patch Set: Guard against empty web contents Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/app_controller_mac.h » ('j') | chrome/browser/app_controller_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8" standalone="no"?> 1 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
2 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersio n="5056" systemVersion="13F34" targetRuntime="MacOSX.Cocoa" propertyAccessContro l="none"> 2 <document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersio n="5056" systemVersion="13F34" targetRuntime="MacOSX.Cocoa" propertyAccessContro l="none">
3 <dependencies> 3 <dependencies>
4 <deployment version="1090" defaultVersion="1060" identifier="macosx"/> 4 <deployment version="1090" defaultVersion="1060" identifier="macosx"/>
5 <development version="5100" identifier="xcode"/> 5 <development version="5100" identifier="xcode"/>
6 <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="505 6"/> 6 <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="505 6"/>
7 </dependencies> 7 </dependencies>
8 <objects> 8 <objects>
9 <customObject id="-2" userLabel="File's Owner" customClass="BrowserCrApp lication"/> 9 <customObject id="-2" userLabel="File's Owner" customClass="BrowserCrApp lication"/>
10 <customObject id="-1" userLabel="First Responder" customClass="FirstResp onder"/> 10 <customObject id="-1" userLabel="First Responder" customClass="FirstResp onder"/>
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 <connections> 132 <connections>
133 <action selector="commandDispatch:" target=" -1" id="528"/> 133 <action selector="commandDispatch:" target=" -1" id="528"/>
134 </connections> 134 </connections>
135 </menuItem> 135 </menuItem>
136 <menuItem title="^IDS_SAVE_PAGE_MAC" tag="35004" key Equivalent="s" id="80"> 136 <menuItem title="^IDS_SAVE_PAGE_MAC" tag="35004" key Equivalent="s" id="80">
137 <connections> 137 <connections>
138 <action selector="commandDispatch:" target=" -1" id="629"/> 138 <action selector="commandDispatch:" target=" -1" id="629"/>
139 </connections> 139 </connections>
140 </menuItem> 140 </menuItem>
141 <menuItem isSeparatorItem="YES" id="452"/> 141 <menuItem isSeparatorItem="YES" id="452"/>
142 <menuItem title="^IDS_EMAIL_PAGE_LOCATION_MAC" tag=" 35006" keyEquivalent="I" id="451"> 142 <menuItem title="Share" id="L1I-I9-Q7f">
143 <connections> 143 <modifierMask key="keyEquivalentModifierMask"/>
144 <action selector="commandDispatch:" target=" -1" id="668"/> 144 <menu key="submenu" title="Share" id="T9x-6Q-SHx ">
Robert Sesek 2017/06/28 15:37:54 Should the title be ^IDS_SHARE_MAC ?
lgrey 2017/06/29 21:11:49 Done.
145 </connections> 145 <items>
146 </items>
147 </menu>
146 </menuItem> 148 </menuItem>
147 <menuItem isSeparatorItem="YES" id="74"/> 149 <menuItem isSeparatorItem="YES" id="74"/>
148 <menuItem title="^IDS_PRINT" tag="35003" keyEquivale nt="p" id="78"> 150 <menuItem title="^IDS_PRINT" tag="35003" keyEquivale nt="p" id="78">
149 <connections> 151 <connections>
150 <action selector="commandDispatch:" target=" -1" id="645"/> 152 <action selector="commandDispatch:" target=" -1" id="645"/>
151 </connections> 153 </connections>
152 </menuItem> 154 </menuItem>
153 <menuItem title="^IDS_PRINT_USING_SYSTEM_DIALOG_MAC" tag="35007" alternate="YES" keyEquivalent="p" id="694"> 155 <menuItem title="^IDS_PRINT_USING_SYSTEM_DIALOG_MAC" tag="35007" alternate="YES" keyEquivalent="p" id="694">
154 <modifierMask key="keyEquivalentModifierMask" op tion="YES" command="YES"/> 156 <modifierMask key="keyEquivalentModifierMask" op tion="YES" command="YES"/>
155 <connections> 157 <connections>
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 <customObject id="483" customClass="AppController"> 574 <customObject id="483" customClass="AppController">
573 <connections> 575 <connections>
574 <outlet property="closeTabMenuItem_" destination="450" id="623"/ > 576 <outlet property="closeTabMenuItem_" destination="450" id="623"/ >
575 <outlet property="closeWindowMenuItem_" destination="73" id="622 "/> 577 <outlet property="closeWindowMenuItem_" destination="73" id="622 "/>
576 <outlet property="helpMenu_" destination="106" id="667"/> 578 <outlet property="helpMenu_" destination="106" id="667"/>
577 </connections> 579 </connections>
578 </customObject> 580 </customObject>
579 <menuItem isSeparatorItem="YES" id="4Sz-Jh-Doh"/> 581 <menuItem isSeparatorItem="YES" id="4Sz-Jh-Doh"/>
580 </objects> 582 </objects>
581 </document> 583 </document>
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/app_controller_mac.h » ('j') | chrome/browser/app_controller_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698