Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2950263003: Use ContainsValue() instead of std::find() in extensions/ (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, jshin+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in extensions/ BUG=561800 Review-Url: https://codereview.chromium.org/2950263003 Cr-Commit-Position: refs/heads/master@{#482550} Committed: https://chromium.googlesource.com/chromium/src/+/4c052438e8d6afd2edbabfc8e0b2f4cb9e59856e

Patch Set 1 #

Patch Set 2 : Rebase patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -32 lines) Patch
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M extensions/browser/api/document_scan/document_scan_api.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/socket/udp_socket.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_window_registry.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/common/extension_l10n_util.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/common/url_pattern_set_unittest.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Tripta
Hi Reilly, Please review code changes for below files: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc extensions/browser/api/document_scan/document_scan_api.cc extensions/browser/api/management/management_api.cc extensions/browser/api/socket/udp_socket.cc extensions/browser/api/web_request/web_request_api.cc extensions/browser/app_window/app_window_registry.cc ...
3 years, 6 months ago (2017-06-22 08:52:24 UTC) #3
Reilly Grant (use Gerrit)
lgtm
3 years, 6 months ago (2017-06-22 15:03:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950263003/1
3 years, 5 months ago (2017-06-27 04:04:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/240316) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-06-27 04:06:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950263003/20001
3 years, 5 months ago (2017-06-27 05:40:42 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 06:30:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c052438e8d6afd2edbabfc8e0b2...

Powered by Google App Engine
This is Rietveld 408576698