Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2950253003: LayoutTests: Disabling more service-worker tests. (Closed)

Created:
1 year, 10 months ago by mithro
Modified:
1 year, 10 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: Disabling more service-worker tests. These tests are flaky on Mac and likely flaky everywhere. TBR=dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org,horo@chromium.org BUG=595993 NOTRY=true Review-Url: https://codereview.chromium.org/2950253003 Cr-Commit-Position: refs/heads/master@{#481807} Committed: https://chromium.googlesource.com/chromium/src/+/e6357aabd4ce4e2f51b3d897f8cd3e0b2da72af4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950253003/1
1 year, 10 months ago (2017-06-23 04:58:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e6357aabd4ce4e2f51b3d897f8cd3e0b2da72af4
1 year, 10 months ago (2017-06-23 05:03:17 UTC) #10
falken
1 year, 10 months ago (2017-06-23 05:15:27 UTC) #11
Message was sent while issue was closed.
On 2017/06/23 05:03:17, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/e6357aabd4ce4e2f51b3d897f8cd...

Thanks for adding the expectation. This is better for BUG=735883. I'll revise
the bug link in TestExpectations. Also since it's failing with a text error,
I'll make the expectations FAIL PASS so we still have the test running.

Powered by Google App Engine
This is Rietveld 408576698