Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2950243002: Adds US International (PC) keyboard title message item. (Closed)

Created:
3 years, 6 months ago by wuyingbing1
Modified:
3 years, 5 months ago
Reviewers:
Shu Chen, Daniel Erat, sky
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds US International (PC) keyboard title message item. BUG=718368 Review-Url: https://codereview.chromium.org/2950243002 Cr-Commit-Position: refs/heads/master@{#482902} Committed: https://chromium.googlesource.com/chromium/src/+/d95e4951a3bab57b4839e3a3d7e64d43c8079d42

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adds US International (PC) keyboard title message item. #

Patch Set 3 : Adds US International (PC) keyboard title message item. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/base/ime/chromeos/input_method_util.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/chromeos/ui_chromeos_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Shu Chen
https://codereview.chromium.org/2950243002/diff/1/ui/chromeos/ui_chromeos_strings.grd File ui/chromeos/ui_chromeos_strings.grd (right): https://codereview.chromium.org/2950243002/diff/1/ui/chromeos/ui_chromeos_strings.grd#newcode741 ui/chromeos/ui_chromeos_strings.grd:741: US International keyboard (PC) This should be: US International ...
3 years, 6 months ago (2017-06-22 02:25:26 UTC) #3
wuyingbing1
On 2017/06/22 02:25:26, Shu Chen wrote: > https://codereview.chromium.org/2950243002/diff/1/ui/chromeos/ui_chromeos_strings.grd > File ui/chromeos/ui_chromeos_strings.grd (right): > > https://codereview.chromium.org/2950243002/diff/1/ui/chromeos/ui_chromeos_strings.grd#newcode741 ...
3 years, 6 months ago (2017-06-22 03:05:48 UTC) #4
Shu Chen
lgtm
3 years, 6 months ago (2017-06-22 03:11:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950243002/40001
3 years, 6 months ago (2017-06-22 03:11:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/470626)
3 years, 6 months ago (2017-06-22 03:18:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950243002/40001
3 years, 6 months ago (2017-06-22 03:26:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/470644)
3 years, 6 months ago (2017-06-22 03:32:40 UTC) #13
wuyingbing1
ping~ Daniel Erat, sky please help to lgtm the CL.
3 years, 5 months ago (2017-06-28 03:17:54 UTC) #16
Daniel Erat
lgtm
3 years, 5 months ago (2017-06-28 03:29:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950243002/40001
3 years, 5 months ago (2017-06-28 05:35:19 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 06:15:34 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d95e4951a3bab57b4839e3a3d7e6...

Powered by Google App Engine
This is Rietveld 408576698