Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: components/browser_watcher/watcher_client_win.h

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/watcher_client_win.h
diff --git a/components/browser_watcher/watcher_client_win.h b/components/browser_watcher/watcher_client_win.h
index 0a6cee0a88bed9758178e92b0b3f1c83cc7eee13..e3e5dadddacc93c78ebb4123fe27ac11c9d70c5c 100644
--- a/components/browser_watcher/watcher_client_win.h
+++ b/components/browser_watcher/watcher_client_win.h
@@ -42,18 +42,7 @@ class WatcherClient {
// Returns the launched process.
const base::Process& process() const { return process_; }
- // Accessors, exposed only for testing.
- bool use_legacy_launch() const { return use_legacy_launch_; }
- void set_use_legacy_launch(bool use_legacy_launch) {
- use_legacy_launch_ = use_legacy_launch;
- }
-
private:
- // If true, the watcher process will be launched with XP legacy handle
- // inheritance. This is not thread safe and can leak random handles into the
- // child process, but it's the best we can do on XP.
- bool use_legacy_launch_;
-
// The CommandLineGenerator passed to the constructor.
CommandLineGenerator command_line_generator_;

Powered by Google App Engine
This is Rietveld 408576698