Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: components/arc/crash_collector/arc_crash_collector_bridge.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Fix Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/crash_collector/arc_crash_collector_bridge.cc
diff --git a/components/arc/crash_collector/arc_crash_collector_bridge.cc b/components/arc/crash_collector/arc_crash_collector_bridge.cc
index 2ca3da4f26a9df02e6dc0b9cb3ccddc300214536..95ef388f23a8c3eb9079e3f6fd3556dec3b666c0 100644
--- a/components/arc/crash_collector/arc_crash_collector_bridge.cc
+++ b/components/arc/crash_collector/arc_crash_collector_bridge.cc
@@ -24,11 +24,9 @@ void RunCrashReporter(const std::string& crash_type,
const std::string& board,
const std::string& cpu_abi,
mojo::edk::ScopedPlatformHandle pipe) {
- base::FileHandleMappingVector fd_map = {
- std::make_pair(pipe.get().handle, STDIN_FILENO)};
-
base::LaunchOptions options;
- options.fds_to_remap = &fd_map;
+ options.fds_to_remap.push_back(
+ std::make_pair(pipe.get().handle, STDIN_FILENO));
auto process =
base::LaunchProcess({kCrashReporterPath, "--arc_java_crash=" + crash_type,

Powered by Google App Engine
This is Rietveld 408576698