Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2950113004:
Fix undefined small pods container error (Closed)
|
Created:
3 years, 6 months ago by Wenzhao (Colin) Zang Modified:
3 years, 6 months ago Reviewers:
xiyuan CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, rkc Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix undefined small pods container error
Previously ignored that this.smallPodsContainer is not defined in the
particular namespace.
BUG=735724
Review-Url: https://codereview.chromium.org/2950113004
Cr-Commit-Position: refs/heads/master@{#482014}
Committed: https://chromium.googlesource.com/chromium/src/+/5f72ae6c4fa56b28257207220d8f84595cc9b11b
Patch Set 1 #Patch Set 2 : use bind #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix undefined small pods container error BUG=735724 ========== to ========== Fix undefined small pods container error Previously ignored that this.smallPodsContainer is not defined in the particular namespace. BUG=735724 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
wzang@chromium.org changed reviewers: + jdufault@chromium.org
jdufault@, PTAL this small CL.
wzang@chromium.org changed reviewers: + xiyuan@chromium.org - jdufault@chromium.org
xiyuan@, PTAL. Thanks! I didn't use bind(this) but if it's better I'll change.
I would prefer bind(this) so that we can use the getters defined to wrap document.querySelector(), which is more of an impl detail. If we change in the future, code using getter does not have to be changed.
On 2017/06/23 17:27:20, xiyuan wrote: > I would prefer bind(this) so that we can use the getters defined to wrap > document.querySelector(), which is more of an impl detail. If we change in the > future, code using getter does not have to be changed. I see. Done.
lgtm
The CQ bit was checked by wzang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by wzang@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498250021741710,
"parent_rev": "50033b4a6a80b5acbb9e565fc9a3463d3c3e7759", "commit_rev":
"29a8598d1db34d3d0d86b424e436524258c3713b"}
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498250021741710,
"parent_rev": "2745df54ac745edf2248dbb35e4944a3fb190c6a", "commit_rev":
"5f72ae6c4fa56b28257207220d8f84595cc9b11b"}
Message was sent while issue was closed.
Description was changed from ========== Fix undefined small pods container error Previously ignored that this.smallPodsContainer is not defined in the particular namespace. BUG=735724 ========== to ========== Fix undefined small pods container error Previously ignored that this.smallPodsContainer is not defined in the particular namespace. BUG=735724 Review-Url: https://codereview.chromium.org/2950113004 Cr-Commit-Position: refs/heads/master@{#482014} Committed: https://chromium.googlesource.com/chromium/src/+/5f72ae6c4fa56b28257207220d8f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5f72ae6c4fa56b28257207220d8f... |
