Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2950083002: Add accelerometer support property to Display. (Closed)

Created:
3 years, 6 months ago by oshima
Modified:
3 years, 6 months ago
Reviewers:
stevenjb, kylechar
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add accelerometer support property to Display. BUG=704929 TEST=covered by unit test Review-Url: https://codereview.chromium.org/2950083002 Cr-Commit-Position: refs/heads/master@{#481690} Committed: https://chromium.googlesource.com/chromium/src/+/f597670d9a6ea1298dac6048389c3a51e45d6434

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed to bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M ash/display/display_manager_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M ash/display/screen_ash.cc View 2 chunks +9 lines, -1 line 0 comments Download
M ui/display/display.h View 3 chunks +15 lines, -0 lines 0 comments Download
M ui/display/manager/display_manager.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/display/manager/display_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
oshima
3 years, 6 months ago (2017-06-21 15:12:23 UTC) #2
stevenjb
lgtm
3 years, 6 months ago (2017-06-21 19:39:25 UTC) #11
oshima
oops bad autocomplete. +kylechar@ this time
3 years, 6 months ago (2017-06-22 15:18:37 UTC) #13
kylechar
The mojom and StructTraits will need to be updated eventually too so the new field ...
3 years, 6 months ago (2017-06-22 15:28:31 UTC) #14
oshima
https://codereview.chromium.org/2950083002/diff/1/ui/display/manager/display_manager.h File ui/display/manager/display_manager.h (right): https://codereview.chromium.org/2950083002/diff/1/ui/display/manager/display_manager.h#newcode497 ui/display/manager/display_manager.h:497: int64_t internal_display_has_accelerometer_ = false; On 2017/06/22 15:28:31, kylechar wrote: ...
3 years, 6 months ago (2017-06-22 18:58:43 UTC) #15
kylechar
lgtm
3 years, 6 months ago (2017-06-22 18:59:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950083002/20001
3 years, 6 months ago (2017-06-22 20:47:24 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 22:18:04 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f597670d9a6ea1298dac6048389c...

Powered by Google App Engine
This is Rietveld 408576698