Chromium Code Reviews
DescriptionOnly call doUpdateVisitedHistory for the main frame.
Before M58 we only called WebViewClient.doUpdateVisitedHistory for main
frame navigations - at some point during navigation refactoring this
appears to have gotten broken. Move the early-exit for non-main-frame
URLs earlier in AwWebContentsObserver to restore the pre-M58 behaviour
and add test coverage for this case.
BUG=732244
Change-Id: I86c4a02180dffe6ceb9cad7590dc11cd0a40f2f8
Reviewed-on: https://chromium-review.googlesource.com/537512
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#480196}
Review-Url: https://codereview.chromium.org/2950043004 .
Cr-Commit-Position: refs/branch-heads/3112@{#424}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/49ec2ff743401d812350dc8e27fb786b5e479957
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||