Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2950043004: Only call doUpdateVisitedHistory for the main frame. (Closed)

Created:
3 years, 6 months ago by Torne
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Only call doUpdateVisitedHistory for the main frame. Before M58 we only called WebViewClient.doUpdateVisitedHistory for main frame navigations - at some point during navigation refactoring this appears to have gotten broken. Move the early-exit for non-main-frame URLs earlier in AwWebContentsObserver to restore the pre-M58 behaviour and add test coverage for this case. BUG=732244 Change-Id: I86c4a02180dffe6ceb9cad7590dc11cd0a40f2f8 Reviewed-on: https://chromium-review.googlesource.com/537512 Reviewed-by: Selim Gurun <sgurun@chromium.org>; Reviewed-by: Richard Coles <torne@chromium.org>; Commit-Queue: Richard Coles <torne@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#480196} Review-Url: https://codereview.chromium.org/2950043004 . Cr-Commit-Position: refs/branch-heads/3112@{#424} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/49ec2ff743401d812350dc8e27fb786b5e479957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java View 2 chunks +5 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Torne
3 years, 6 months ago (2017-06-21 20:21:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
49ec2ff743401d812350dc8e27fb786b5e479957.

Powered by Google App Engine
This is Rietveld 408576698