Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2950013002: Revert of Use CTFontCreateForString for RenderTextHarfbuzz on Mac (Closed)

Created:
3 years, 6 months ago by tapted
Modified:
3 years, 6 months ago
CC:
chromium-reviews, derat+watch_chromium.org, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use CTFontCreateForString for RenderTextHarfbuzz on Mac (patchset #5 id:80001 of https://codereview.chromium.org/2927953003/ ) Reason for revert: Causes views_unittest LabelSelectionTest.MouseDragSingleLineRTL to fail on 10.10 and 10.11 Original issue's description: > Use CTFontCreateForString for RenderTextHarfbuzz on Mac > > The approach ends up pretty close to what's already done for Windows. > > On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more > often match what native UI does) and requires RenderTextHarfbuzz to do > less work. However, it doesn't guarantee that the returned font can > display every glyph in the provided string. > > So still use CTFontCopyDefaultCascadeListForLanguages (which is now a > public API - hooray) to provide a last-resort list of fallback fonts. > > BUG=696867, 619684 > > Review-Url: https://codereview.chromium.org/2927953003 > Cr-Commit-Position: refs/heads/master@{#481062} > Committed: https://chromium.googlesource.com/chromium/src/+/62cbc10d4dbfeed614eb23c3d996793814a35334 TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696867, 619684 Review-Url: https://codereview.chromium.org/2950013002 Cr-Commit-Position: refs/heads/master@{#481095} Committed: https://chromium.googlesource.com/chromium/src/+/dca011e454153e08602ead192cda84abc2946a64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -88 lines) Patch
M ui/gfx/font_fallback.h View 2 chunks +0 lines, -14 lines 0 comments Download
M ui/gfx/font_fallback_mac.mm View 2 chunks +13 lines, -43 lines 0 comments Download
M ui/gfx/font_fallback_mac_unittest.cc View 3 chunks +1 line, -18 lines 0 comments Download
M ui/gfx/font_fallback_win.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 5 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tapted
Created Revert of Use CTFontCreateForString for RenderTextHarfbuzz on Mac
3 years, 6 months ago (2017-06-21 02:57:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950013002/1
3 years, 6 months ago (2017-06-21 02:57:47 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 02:58:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dca011e454153e08602ead192cda...

Powered by Google App Engine
This is Rietveld 408576698