DescriptionRevert of Use CTFontCreateForString for RenderTextHarfbuzz on Mac (patchset #5 id:80001 of https://codereview.chromium.org/2927953003/ )
Reason for revert:
Causes views_unittest LabelSelectionTest.MouseDragSingleLineRTL to fail on 10.10 and 10.11
Original issue's description:
> Use CTFontCreateForString for RenderTextHarfbuzz on Mac
>
> The approach ends up pretty close to what's already done for Windows.
>
> On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more
> often match what native UI does) and requires RenderTextHarfbuzz to do
> less work. However, it doesn't guarantee that the returned font can
> display every glyph in the provided string.
>
> So still use CTFontCopyDefaultCascadeListForLanguages (which is now a
> public API - hooray) to provide a last-resort list of fallback fonts.
>
> BUG=696867, 619684
>
> Review-Url: https://codereview.chromium.org/2927953003
> Cr-Commit-Position: refs/heads/master@{#481062}
> Committed: https://chromium.googlesource.com/chromium/src/+/62cbc10d4dbfeed614eb23c3d996793814a35334
TBR=asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=696867, 619684
Review-Url: https://codereview.chromium.org/2950013002
Cr-Commit-Position: refs/heads/master@{#481095}
Committed: https://chromium.googlesource.com/chromium/src/+/dca011e454153e08602ead192cda84abc2946a64
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|