Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2949993002: Don't ignore manifest icons for sites that don't have a service worker. (Closed)
Patch Set: Fix up icon handling Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index d60e013bc216402d065ec97ab526b5f66640a69c..796a9eeab2f87b808379fcd4821b704b5b262203 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -149,7 +149,7 @@ AppBannerManager::AppBannerManager(content::WebContents* web_contents)
SiteEngagementObserver(SiteEngagementService::Get(
Profile::FromBrowserContext(web_contents->GetBrowserContext()))),
state_(State::INACTIVE),
- manager_(nullptr),
+ manager_(InstallableManager::FromWebContents(web_contents)),
event_request_id_(-1),
binding_(this),
has_sufficient_engagement_(false),
@@ -158,9 +158,6 @@ AppBannerManager::AppBannerManager(content::WebContents* web_contents)
triggered_by_devtools_(false),
need_to_log_status_(false),
weak_factory_(this) {
- // Ensure the InstallableManager exists since we have a hard dependency on it.
- InstallableManager::CreateForWebContents(web_contents);
- manager_ = InstallableManager::FromWebContents(web_contents);
DCHECK(manager_);
AppBannerSettingsHelper::UpdateFromFieldTrial();

Powered by Google App Engine
This is Rietveld 408576698