chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc - Issue 2949993002: Don't ignore manifest icons for sites that don't have a service worker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Issue 2949993002: Don't ignore manifest icons for sites that don't have a service worker. (Closed)

Patch Set: Fix up icon handling Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

index 8725d7ff0162e89ecb6ed5bb2fccaef94acc377a..cb8ed5b70ac60c71363d28a9dd9a13b8ad11ee80 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

@@ -17,6 +17,7 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/time/time.h"

+#include "chrome/browser/installable/installable_manager.h"

#include "chrome/common/web_application_info.h"

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

@@ -196,6 +197,7 @@ class AddToHomescreenDataFetcherTest : public ChromeRenderViewHostTestHarness {

MockWebContents* mock_web_contents = new MockWebContents(browser_context());

mock_web_contents->Init(content::WebContents::CreateParams(

browser_context(), std::move(site_instance)));

+ InstallableManager::CreateForWebContents(mock_web_contents);

SetContents(mock_web_contents);

}