Inline BucketRanges::set_range

Inline BucketRanges::set_range

This is hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324
Review-Url: https://codereview.chromium.org/2949983002
Cr-Commit-Position: refs/heads/master@{#481092}
Committed: https://chromium.googlesource.com/chromium/src/+/7fca9e960b25c90e214c7e900873ae73202d7720

[hans, 2017-06-21 00:36:28]

hans@chromium.org changed reviewers:
+ rkaplow@chromium.org, thakis@chromium.org

[hans, 2017-06-21 00:36:28]

Please take a look.

[Nico, 2017-06-21 01:03:37]

lgtm

https://codereview.chromium.org/2949983002/diff/1/base/metrics/bucket_ranges.h
File base/metrics/bucket_ranges.h (right):

https://codereview.chromium.org/2949983002/diff/1/base/metrics/bucket_ranges....
base/metrics/bucket_ranges.h:46: ranges_[i] = value;
Kind of weird that one is a dcheck but the other a check

[hans, 2017-06-21 01:11:47]

https://codereview.chromium.org/2949983002/diff/1/base/metrics/bucket_ranges.h
File base/metrics/bucket_ranges.h (right):

https://codereview.chromium.org/2949983002/diff/1/base/metrics/bucket_ranges....
base/metrics/bucket_ranges.h:46: ranges_[i] = value;
On 2017/06/21 01:03:37, Nico wrote:
> Kind of weird that one is a dcheck but the other a check

Good point. It was added in https://chromiumcodereview.appspot.com/10857025 five
years ago "Add more code for debugging. We will revert this change when we find
out the reason of corruption."

Let's change it to a DCHECK..

[hans, 2017-06-21 01:11:54]

The CQ bit was checked by hans@chromium.org

[hans, 2017-06-21 01:11:55]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2949983002/#ps20001
(title: "switch to dcheck")

[commit-bot: I haz the power, 2017-06-21 01:12:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 02:41:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498007514697410,
"parent_rev": "5e3bdec771619fd558e176dafe393bfe1690078a", "commit_rev":
"7fca9e960b25c90e214c7e900873ae73202d7720"}

[commit-bot: I haz the power, 2017-06-21 02:41:27]

Description was changed from

==========
Inline BucketRanges::set_range

This is hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324
==========

to

==========
Inline BucketRanges::set_range

This is hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324

Review-Url: https://codereview.chromium.org/2949983002
Cr-Commit-Position: refs/heads/master@{#481092}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fca9e960b25c90e214c7e900873...
==========

[commit-bot: I haz the power, 2017-06-21 02:41:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7fca9e960b25c90e214c7e900873...