Introduce lock screen app manager interface

chrome/browser/chromeos/note_taking_helper_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/note_taking_helper.h"
 
 #include <utility>
 
 #include "ash/ash_switches.h"
 #include "base/bind.h"
@@ skipping 345 matching lines @@
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(2u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[0]));
   EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
                          kProdKeepAppName, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[1]));
+  EXPECT_FALSE(helper()->GetPreferredChromeAppInfo(profile()));
 
   // Now install a random extension and check that it's ignored.
   const extensions::ExtensionId kOtherId = crx_file::id_util::GenerateId("a");
   const std::string kOtherName = "Some Other App";
   scoped_refptr<const extensions::Extension> other_extension =
       CreateExtension(kOtherId, kOtherName);
   InstallExtension(other_extension.get(), profile());
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(2u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[0]));
   EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
                          kProdKeepAppName, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[1]));
+  EXPECT_FALSE(helper()->GetPreferredChromeAppInfo(profile()));
 
   // Mark the prod version as preferred.
   helper()->SetPreferredApp(profile(), NoteTakingHelper::kProdKeepExtensionId);
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(2u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[0]));
   EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
                          kProdKeepAppName, true /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[1]));
+
+  std::unique_ptr<NoteTakingAppInfo> preferred_info =
+      helper()->GetPreferredChromeAppInfo(profile());
+  ASSERT_TRUE(preferred_info);
+  EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
+                         kProdKeepAppName, true /* preferred */,
+                         NoteTakingLockScreenSupport::kNotSupported),
+            GetAppString(*preferred_info));
 }
 
 TEST_P(NoteTakingHelperTest, ListChromeAppsWithLockScreenNotesSupported) {
   Init(ENABLE_PALETTE | ENABLE_LOCK_SCREEN_APPS);
 
   ASSERT_FALSE(helper()->IsAppAvailable(profile()));
   ASSERT_TRUE(helper()->GetAvailableApps(profile()).empty());
 
   std::unique_ptr<base::Value> lock_disabled_action_handler =
       extensions::ListBuilder()
           .Append(app_runtime::ToString(app_runtime::ACTION_TYPE_NEW_NOTE))
           .Build();
 
   // Install Keep app that does not support lock screen note taking - it should
   // be reported not to support lock screen note taking.
   scoped_refptr<const extensions::Extension> prod_extension = CreateExtension(
       NoteTakingHelper::kProdKeepExtensionId, kProdKeepAppName,
       nullptr /* permissions */, std::move(lock_disabled_action_handler));
   InstallExtension(prod_extension.get(), profile());
   EXPECT_TRUE(helper()->IsAppAvailable(profile()));
   std::vector<NoteTakingAppInfo> apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(1u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
                          kProdKeepAppName, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[0]));
+  EXPECT_FALSE(helper()->GetPreferredChromeAppInfo(profile()));
 
   std::unique_ptr<base::Value> lock_enabled_action_handler =
       extensions::ListBuilder()
           .Append(extensions::DictionaryBuilder()
                       .Set("action", app_runtime::ToString(
                                          app_runtime::ACTION_TYPE_NEW_NOTE))
                       .SetBoolean("enabled_on_lock_screen", true)
                       .Build())
           .Build();
 
   // Install additional Keep app - one that supports lock screen note taking.
   // This app should be reported to support note taking (given that
   // enable-lock-screen-apps flag is set).
   scoped_refptr<const extensions::Extension> dev_extension =
       CreateExtension(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                       extensions::ListBuilder().Append("lockScreen").Build(),
                       std::move(lock_enabled_action_handler));
   InstallExtension(dev_extension.get(), profile());
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(2u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          false /* preferred */,
                          NoteTakingLockScreenSupport::kSupported),
             GetAppString(apps[0]));
   EXPECT_EQ(GetAppString(NoteTakingHelper::kProdKeepExtensionId,
                          kProdKeepAppName, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[1]));
+  EXPECT_FALSE(helper()->GetPreferredChromeAppInfo(profile()));
 }
 
 TEST_P(NoteTakingHelperTest, PreferredAppEnabledOnLockScreen) {
   Init(ENABLE_PALETTE | ENABLE_LOCK_SCREEN_APPS);
 
   ASSERT_FALSE(helper()->IsAppAvailable(profile()));
   ASSERT_TRUE(helper()->GetAvailableApps(profile()).empty());
 
   std::unique_ptr<base::Value> lock_enabled_action_handler =
       extensions::ListBuilder()
@@ skipping 11 matching lines @@
                       std::move(lock_enabled_action_handler));
   InstallExtension(dev_extension.get(), profile());
 
   // Verify that the app is reported to support lock screen note taking.
   std::vector<NoteTakingAppInfo> apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(1u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          false /* preferred */,
                          NoteTakingLockScreenSupport::kSupported),
             GetAppString(apps[0]));
+  EXPECT_FALSE(helper()->GetPreferredChromeAppInfo(profile()));
 
   // When the lock screen note taking pref is set and the Keep app is set as the
   // preferred note taking app, the app should be reported as selected as lock
   // screen note taking app.
   helper()->SetPreferredApp(profile(), NoteTakingHelper::kDevKeepExtensionId);
   profile()->GetPrefs()->SetBoolean(prefs::kNoteTakingAppEnabledOnLockScreen,
                                     true);
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(1u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          true /* preferred */,
                          NoteTakingLockScreenSupport::kSelected),
             GetAppString(apps[0]));
+  std::unique_ptr<NoteTakingAppInfo> preferred_info =
+      helper()->GetPreferredChromeAppInfo(profile());
+  ASSERT_TRUE(preferred_info);
+  EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
+                         true /* preferred */,
+                         NoteTakingLockScreenSupport::kSelected),
+            GetAppString(*preferred_info));
 
   // When lock screen note taking pref is reset, the app should not be reported
   // as selected on lock screen.
   profile()->GetPrefs()->SetBoolean(prefs::kNoteTakingAppEnabledOnLockScreen,
                                     false);
   apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(1u, apps.size());
   EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
                          true /* preferred */,
                          NoteTakingLockScreenSupport::kSupported),
             GetAppString(apps[0]));
+  preferred_info = helper()->GetPreferredChromeAppInfo(profile());
+  ASSERT_TRUE(preferred_info);
+  EXPECT_EQ(GetAppString(NoteTakingHelper::kDevKeepExtensionId, kDevKeepAppName,
+                         true /* preferred */,
+                         NoteTakingLockScreenSupport::kSupported),
+            GetAppString(*preferred_info));
 }
 
 TEST_P(NoteTakingHelperTest, PreferredAppWithNoLockScreenPermission) {
   Init(ENABLE_PALETTE | ENABLE_LOCK_SCREEN_APPS);
 
   ASSERT_FALSE(helper()->IsAppAvailable(profile()));
   ASSERT_TRUE(helper()->GetAvailableApps(profile()).empty());
 
   std::unique_ptr<base::Value> lock_enabled_action_handler =
       extensions::ListBuilder()
@@ skipping 405 matching lines @@
   EXPECT_TRUE(helper()->IsAppAvailable(profile()));
   std::vector<NoteTakingAppInfo> apps = helper()->GetAvailableApps(profile());
   ASSERT_EQ(2u, apps.size());
   EXPECT_EQ(GetAppString(kPackage1, kName1, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[0]));
   EXPECT_EQ(GetAppString(kPackage2, kName2, false /* preferred */,
                          NoteTakingLockScreenSupport::kNotSupported),
             GetAppString(apps[1]));
 
+  helper()->SetPreferredApp(profile(), kPackage1);
+
+  apps = helper()->GetAvailableApps(profile());
+  ASSERT_EQ(2u, apps.size());
+  EXPECT_EQ(GetAppString(kPackage1, kName1, true /* preferred */,
+                         NoteTakingLockScreenSupport::kNotSupported),
+            GetAppString(apps[0]));
+  EXPECT_EQ(GetAppString(kPackage2, kName2, false /* preferred */,
+                         NoteTakingLockScreenSupport::kNotSupported),
+            GetAppString(apps[1]));
+
+  std::unique_ptr<NoteTakingAppInfo> preferred_info =
+      helper()->GetPreferredChromeAppInfo(profile());
+  EXPECT_FALSE(preferred_info);
+
   // TODO(victorhsieh): Opt-out on Persistent ARC is special.  Skip until
   // implemented.
   if (arc::ShouldArcAlwaysStart())
     return;
   // Disable Play Store and check that the apps are no longer returned.
   profile()->GetPrefs()->SetBoolean(prefs::kArcEnabled, false);
   EXPECT_FALSE(helper()->play_store_enabled());
   EXPECT_FALSE(helper()->android_apps_received());
   EXPECT_FALSE(helper()->IsAppAvailable(profile()));
   EXPECT_TRUE(helper()->GetAvailableApps(profile()).empty());
@@ skipping 170 matching lines @@
   InitExtensionService(second_profile);
   EXPECT_EQ(0, observer.num_updates());
   InstallExtension(keep_extension.get(), second_profile);
   EXPECT_EQ(1, observer.num_updates());
   UninstallExtension(keep_extension.get(), second_profile);
   EXPECT_EQ(2, observer.num_updates());
   profile_manager_->DeleteTestingProfile(kSecondProfileName);
 }
 
 }  // namespace chromeos