Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2949943003: Introduce lock screen app manager interface (Closed)

Created:
3 years, 6 months ago by tbarzic
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Devlin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce lock screen app manager interface The manager will be responsible for managing the lock screen note taking app (if one is selected) in the profile used for lock screen apps. StateController starts the manager when the user session is locked and stops it when user session is unlocked. Additionally, StateController will use lock screen AppManager to determine whether a lock screen enabled note taking app is set up, and to dispatch launch event to the app in question. Currently, the app manager implementation is stubbed out - it will be added in subsequent patches. BUG=715781 Review-Url: https://codereview.chromium.org/2949943003 Cr-Commit-Position: refs/heads/master@{#481279} Committed: https://chromium.googlesource.com/chromium/src/+/1d75a1d92beee4cb3a492375d5f55094b7f82229

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -16 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/lock_screen_apps/app_manager.h View 1 1 chunk +62 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/lock_screen_apps/app_manager_impl.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/lock_screen_apps/app_manager_impl.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.h View 6 chunks +27 lines, -1 line 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller.cc View 6 chunks +60 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc View 12 chunks +401 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/session/chrome_session_manager.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/note_taking_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/note_taking_helper.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/note_taking_helper_unittest.cc View 9 chunks +41 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
tbarzic
Splitting out (uncontested) parts of https://codereview.chromium.org/2902293002/ to unblock few other cls. Can you please take ...
3 years, 6 months ago (2017-06-20 22:43:59 UTC) #4
xiyuan
lgtm https://codereview.chromium.org/2949943003/diff/1/chrome/browser/chromeos/lock_screen_apps/app_manager.h File chrome/browser/chromeos/lock_screen_apps/app_manager.h (right): https://codereview.chromium.org/2949943003/diff/1/chrome/browser/chromeos/lock_screen_apps/app_manager.h#newcode10 chrome/browser/chromeos/lock_screen_apps/app_manager.h:10: #include "base/callback.h" nit: Include callback_forward.h here and callback.h ...
3 years, 6 months ago (2017-06-21 16:09:47 UTC) #7
tbarzic
https://codereview.chromium.org/2949943003/diff/1/chrome/browser/chromeos/lock_screen_apps/app_manager.h File chrome/browser/chromeos/lock_screen_apps/app_manager.h (right): https://codereview.chromium.org/2949943003/diff/1/chrome/browser/chromeos/lock_screen_apps/app_manager.h#newcode10 chrome/browser/chromeos/lock_screen_apps/app_manager.h:10: #include "base/callback.h" On 2017/06/21 16:09:47, xiyuan wrote: > nit: ...
3 years, 6 months ago (2017-06-21 16:56:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949943003/20001
3 years, 6 months ago (2017-06-21 16:57:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/439088)
3 years, 6 months ago (2017-06-21 17:48:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949943003/20001
3 years, 6 months ago (2017-06-21 17:50:36 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 19:44:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d75a1d92beee4cb3a492375d5f5...

Powered by Google App Engine
This is Rietveld 408576698