Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2949903002: Fix search engine promo from web search action mode in CCTs. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix search engine promo from web search action mode in CCTs. BUG=735145 Review-Url: https://codereview.chromium.org/2949903002 Cr-Commit-Position: refs/heads/master@{#481060} Committed: https://chromium.googlesource.com/chromium/src/+/dcdf6225ca8644f520cefebe4845ff2948fad8b2

Patch Set 1 #

Patch Set 2 : Add tests #

Total comments: 1

Patch Set 3 : Clear statics in junit code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java View 1 3 chunks +28 lines, -10 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/ChromeActionModeCallbackTest.java View 1 2 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-20 20:29:14 UTC) #2
Yusuf
https://codereview.chromium.org/2949903002/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/ChromeActionModeCallbackTest.java File chrome/android/junit/src/org/chromium/chrome/browser/ChromeActionModeCallbackTest.java (right): https://codereview.chromium.org/2949903002/diff/20001/chrome/android/junit/src/org/chromium/chrome/browser/ChromeActionModeCallbackTest.java#newcode86 chrome/android/junit/src/org/chromium/chrome/browser/ChromeActionModeCallbackTest.java:86: Mockito.when(mActionModeCallbackHelper.getSelectedText()).thenReturn("OhHai"); Oh Hai! :P
3 years, 6 months ago (2017-06-20 21:35:06 UTC) #7
Yusuf
lgtm
3 years, 6 months ago (2017-06-20 21:35:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949903002/40001
3 years, 6 months ago (2017-06-20 23:33:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/483941)
3 years, 6 months ago (2017-06-21 00:03:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949903002/40001
3 years, 6 months ago (2017-06-21 00:22:47 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 01:17:22 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dcdf6225ca8644f520cefebe4845...

Powered by Google App Engine
This is Rietveld 408576698